Skip to content

Commit 3ca1094

Browse files
authored
Merge pull request #3551 from alfonso-salces/MOBILE-4077
Mobile 4077
2 parents 12546f6 + 3781835 commit 3ca1094

File tree

4 files changed

+26
-12
lines changed

4 files changed

+26
-12
lines changed

src/core/features/reportbuilder/components/report-column/report-column.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,25 +12,31 @@
1212
// See the License for the specific language governing permissions and
1313
// limitations under the License.
1414

15-
import { Component, EventEmitter, Input, Output } from '@angular/core';
15+
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
1616

1717
@Component({
1818
selector: 'core-report-builder-report-column',
1919
templateUrl: './report-column.html',
2020
styleUrls: ['./report-column.scss'],
2121
})
22-
export class CoreReportBuilderReportColumnComponent {
22+
export class CoreReportBuilderReportColumnComponent implements OnInit {
2323

2424
@Input() isExpanded = false;
2525
@Input() isExpandable = false;
2626
@Input() showFirstTitle = false;
2727
@Input() columnIndex!: number;
2828
@Input() rowIndex!: number;
29-
@Input() column!: string;
29+
@Input() column!: string | number;
3030
@Input() contextId!: number;
3131
@Input() header!: string;
3232
@Output() onToggleRow: EventEmitter<number> = new EventEmitter();
3333

34+
ngOnInit(): void {
35+
if (typeof this.column === 'number') {
36+
this.column = this.column.toString();
37+
}
38+
}
39+
3440
/**
3541
* Emits row click
3642
*/

src/core/features/reportbuilder/components/report-detail/report-detail.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
<core-loading [hideUntil]="state.loaded">
44

5-
<ng-container *ngIf="state.report?.data?.rows && state.report?.data?.headers && state.report?.details; else empty">
5+
<ion-refresher slot="fixed" [disabled]="!state.loaded" (ionRefresh)="refreshReport($event.target)">
6+
<ion-refresher-content pullingText="{{ 'core.pulltorefresh' | translate }}"></ion-refresher-content>
7+
</ion-refresher>
68

7-
<ion-refresher slot="fixed" [disabled]="!state.loaded" (ionRefresh)="refreshReport($event.target)">
8-
<ion-refresher-content pullingText="{{ 'core.pulltorefresh' | translate }}"></ion-refresher-content>
9-
</ion-refresher>
9+
<ng-container *ngIf="state.report?.data?.rows?.length && state.report?.data?.headers && state.report?.details; else empty">
1010

1111
<ng-container *ngIf="isCardLayout">
1212
<ion-card *ngFor="let row of state.report.data.rows; let rowIndex = index">
@@ -46,15 +46,15 @@
4646
</ng-container>
4747

4848
<ng-template #empty>
49-
<core-empty-box *ngIf="!state.report?.data?.rows || !state.report?.data?.headers || !state.report?.details" icon="fa-list-alt"
50-
[message]="'core.course.nocontentavailable' | translate"></core-empty-box>
49+
<core-empty-box icon="fa-list-alt">
50+
<p> {{ 'core.course.nocontentavailable' | translate }} </p>
51+
</core-empty-box>
5152
</ng-template>
5253

53-
<core-infinite-loading *ngIf="!isBlock && state.report?.data?.rows && state.report?.data?.headers && state.report?.details"
54+
<core-infinite-loading *ngIf="!isBlock && state.report?.data?.rows?.length && state.report?.data?.headers && state.report?.details"
5455
[enabled]="state.canLoadMoreRows" (action)="fetchMoreInfo($event)" [error]="state.errorLoadingRows">
5556
</core-infinite-loading>
5657

57-
5858
</core-loading>
5959

6060
</ng-container>

src/core/features/reportbuilder/components/report-detail/report-detail.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,12 @@
4141
}
4242

4343
}
44+
45+
core-empty-box {
46+
color: var(--gray-500);
47+
p {
48+
color: var(--gray-900);
49+
}
50+
}
51+
4452
}

src/core/features/reportbuilder/services/reportbuilder.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ export interface CoreReportBuilderRetrieveReportMapped extends Omit<CoreReportBu
232232
export type CoreReportBuilderReportDataWSResponse = {
233233
headers: string[]; // Headers.
234234
rows: { // Rows.
235-
columns: string[]; // Columns.
235+
columns: string | number[]; // Columns.
236236
isExpanded: boolean;
237237
}[];
238238
totalrowcount: number; // Totalrowcount.

0 commit comments

Comments
 (0)