Skip to content

Commit 453059d

Browse files
committed
Merge pull request #418 from dpalou/MOBILE-1457
MOBILE-1457 courses: Fix courses filter
2 parents b405a0a + 2c505be commit 453059d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

www/core/components/courses/controllers/list.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ angular.module('mm.core.courses')
2626

2727
$scope.searchEnabled = $mmCourses.isSearchCoursesAvailable();
2828
$scope.areNavHandlersLoadedFor = $mmCoursesDelegate.areNavHandlersLoadedFor;
29+
$scope.filter = {};
2930

3031
// Convenience function to fetch courses.
3132
function fetchCourses(refresh) {
@@ -34,7 +35,7 @@ angular.module('mm.core.courses')
3435
angular.forEach(courses, function(course) {
3536
course._handlers = $mmCoursesDelegate.getNavHandlersFor(course.id, refresh);
3637
});
37-
$scope.filterText = ''; // Filter value MUST be set after courses are shown.
38+
$scope.filter.filterText = ''; // Filter value MUST be set after courses are shown.
3839
}, function(error) {
3940
if (typeof error != 'undefined' && error !== '') {
4041
$mmUtil.showErrorModal(error);

www/core/components/courses/templates/list.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
<div class="list" ng-if="courses && courses.length > 5">
1111
<label class="item item-input">
1212
<i class="icon ion-funnel placeholder-icon"></i>
13-
<input type="text" placeholder="{{ 'mm.courses.filtermycourses' | translate}}" ng-model="filterText">
13+
<input type="text" placeholder="{{ 'mm.courses.filtermycourses' | translate}}" ng-model="filter.filterText">
1414
</label>
1515
</div>
16-
<section ng-repeat="course in courses | filter:{fullname: filterText}" class="list card">
16+
<section ng-repeat="course in courses | filter:{fullname: filter.filterText}" class="list card">
1717
<a class="item" ui-sref="site.mm_course({courseid: course.id})" title="{{course.fullname}}">
1818
<h2><mm-format-text watch="true">{{course.fullname}}</mm-format-text></h2>
1919
</a>

0 commit comments

Comments
 (0)