Skip to content

Commit 477254e

Browse files
authored
Merge pull request #3290 from dpalou/MOBILE-4082
MOBILE-4082 video: Fix subtitles wider than video
2 parents 9d3a97d + 995b475 commit 477254e

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

src/core/directives/external-content.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ import { CoreFilepool, CoreFilepoolFileActions, CoreFilepoolFileEventData } from
2929
import { CoreSites } from '@services/sites';
3030
import { CoreUrlUtils } from '@services/utils/url';
3131
import { CoreUtils } from '@services/utils/utils';
32-
import { Platform } from '@singletons';
3332
import { CoreLogger } from '@singletons/logger';
3433
import { CoreError } from '@classes/errors/error';
3534
import { CoreSite } from '@classes/site';
@@ -304,12 +303,10 @@ export class CoreExternalContentDirective implements AfterViewInit, OnChanges, O
304303
return;
305304
}
306305

307-
const line = Platform.is('tablet') || CoreApp.isAndroid() ? 90 : 80;
308306
// Position all subtitles to a percentage of video height.
309-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
310-
Array.from(track.cues).forEach((cue: any) => {
307+
Array.from(track.cues).forEach((cue: VTTCue) => {
311308
cue.snapToLines = false;
312-
cue.line = line;
309+
cue.line = 90;
313310
cue.size = 100; // This solves some Android issue.
314311
});
315312
// Delete listener.

src/theme/theme.base.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,3 +1725,8 @@ ion-header.no-title {
17251725
bottom: 0;
17261726
}
17271727
}
1728+
1729+
// Fix subtitles wider than video.
1730+
video::-webkit-media-text-track-display {
1731+
white-space: normal !important;
1732+
}

0 commit comments

Comments
 (0)