MOBILE-4864 chore: Ion buttons on toolbar should have clear filling

Author: crazyserver

src/addons/mod/data/components/index/addon-mod-data-index.html

@@ -1,7 +1,7 @@
 <!-- Buttons to add to the header. -->
 <core-navbar-buttons slot="end">
     @if (canSearch) {
-        <ion-button (click)="showSearch()" [ariaLabel]="'addon.mod_data.search' | translate">
+        <ion-button fill="clear" (click)="showSearch()" [ariaLabel]="'addon.mod_data.search' | translate">
             <ion-icon name="fas-magnifying-glass" slot="icon-only" aria-hidden="true" />
         </ion-button>
     }

src/addons/mod/glossary/components/index/addon-mod-glossary-index.html

@@ -2,12 +2,12 @@
 <core-navbar-buttons slot="end">
     @if (!showLoading && glossary) {
         @if (glossary.browsemodes && glossary.browsemodes.length > 1) {
-            <ion-button (click)="openModePicker($event)" [ariaLabel]="'addon.mod_glossary.browsemode' | translate">
+            <ion-button fill="clear" (click)="openModePicker($event)" [ariaLabel]="'addon.mod_glossary.browsemode' | translate">
                 <ion-icon name="fas-sort" slot="icon-only" aria-hidden="true" />
             </ion-button>
         }
 
-        <ion-button (click)="toggleSearch()" [ariaLabel]="'addon.mod_glossary.bysearch' | translate">
+        <ion-button fill="clear" (click)="toggleSearch()" [ariaLabel]="'addon.mod_glossary.bysearch' | translate">
             <ion-icon name="fas-magnifying-glass" slot="icon-only" aria-hidden="true" />
         </ion-button>
     }

src/addons/mod/wiki/components/index/addon-mod-wiki-index.html

@@ -2,7 +2,8 @@
 <core-navbar-buttons slot="end">
     <!-- Select subwiki. -->
     @if (subwikiData.count > 1) {
-        <ion-button (click)="showSubwikiPicker($event)" [ariaLabel]="'addon.mod_wiki.subwiki' | translate" aria-haspopup="true">
+        <ion-button fill="clear" (click)="showSubwikiPicker($event)" [ariaLabel]="'addon.mod_wiki.subwiki' | translate"
+            aria-haspopup="true">
             @if (!groupWiki) {
                 <ion-icon name="fas-user" aria-hidden="true" />
             } @else {
@@ -12,7 +13,7 @@
     }
 
     @if (!showLoading && currentPageObj) {
-        <ion-button (click)="openMap()" [ariaLabel]="'addon.mod_wiki.map' | translate" aria-haspopup="true">
+        <ion-button fill="clear" (click)="openMap()" [ariaLabel]="'addon.mod_wiki.map' | translate" aria-haspopup="true">
             <ion-icon name="fas-map" aria-hidden="true" />
         </ion-button>
     }

src/core/components/navbar-buttons/navbar-buttons.ts

@@ -36,7 +36,7 @@ const BUTTON_HIDDEN_CLASS = 'core-navbar-button-hidden';
  * Example usage:
  *
  * <core-navbar-buttons slot="end">
- *     <ion-button [class.hidden]="!buttonShown" [ariaLabel]="Do something" (click)="action()">
+ *     <ion-button fill="clear" [class.hidden]="!buttonShown" [ariaLabel]="Do something" (click)="action()">
  *         <ion-icon name="funnel" slot="icon-only" aria-hidden="true"></ion-icon>
  *     </ion-button>
  * </core-navbar-buttons>

src/core/features/courses/pages/dashboard/dashboard.html

@@ -1,6 +1,6 @@
 <core-navbar-buttons slot="end" prepend>
     @if (searchEnabled) {
-        <ion-button (click)="openSearch()" [ariaLabel]="'core.courses.searchcourses' | translate">
+        <ion-button fill="clear" (click)="openSearch()" [ariaLabel]="'core.courses.searchcourses' | translate">
             <ion-icon name="fas-magnifying-glass" slot="icon-only" aria-hidden="true" />
         </ion-button>
     }

src/core/features/login/tests/behat/basic_usage.feature

@@ -38,6 +38,7 @@ Feature: Test basic usage of login in app
     When I restart the app
     Then I should find "Connect to Moodle" in the app
 
+  @test
   Scenario: Add a new account in the app & Site name in displayed when adding a new account
     When I launch the app
     And I set the field "Your site" to "$WWWROOT" in the app

src/core/features/settings/pages/synchronization/synchronization.html

@@ -8,7 +8,7 @@ <h1>{{ 'core.settings.synchronization' | translate }}</h1>
         </ion-title>
         <ion-buttons slot="end">
             <core-navbar-buttons>
-                <ion-button (click)="showInfo()" [ariaLabel]="'core.info' | translate">
+                <ion-button fill="clear" (click)="showInfo()" [ariaLabel]="'core.info' | translate">
                     <ion-icon name="fas-circle-info" slot="icon-only" aria-hidden="true" />
                 </ion-button>
             </core-navbar-buttons>

src/core/features/sitehome/pages/index/index.html

@@ -1,6 +1,6 @@
 <core-navbar-buttons slot="end" prepend>
     @if (searchEnabled) {
-        <ion-button (click)="openSearch()" [ariaLabel]="'core.courses.searchcourses' | translate">
+        <ion-button fill="clear" (click)="openSearch()" [ariaLabel]="'core.courses.searchcourses' | translate">
             <ion-icon name="fas-magnifying-glass" slot="icon-only" aria-hidden="true" />
         </ion-button>
     }