MOBILE-1572 courses: Treat showgrades/enablecompletion = null as 1

jleyva · jleyva · commit 4bcef322f033 · 2016-05-10T15:48:07.000+02:00
diff --git a/www/addons/coursecompletion/services/coursecompletion.js b/www/addons/coursecompletion/services/coursecompletion.js
@@ -176,7 +176,7 @@ angular.module('mm.addons.coursecompletion')
         }
 
         return $mmCourses.getUserCourse(courseId, true).then(function(course) {
-            if (course && typeof course.enablecompletion != 'undefined' && !course.enablecompletion) {
+            if (course && typeof course.enablecompletion != 'undefined' && course.enablecompletion == 0) {
                 return false;
             }
             return true;
diff --git a/www/addons/grades/services/grades.js b/www/addons/grades/services/grades.js
@@ -217,7 +217,7 @@ angular.module('mm.addons.grades')
         }
 
         return $mmCourses.getUserCourse(courseId, true, siteId).then(function(course) {
-            if (course && typeof course.showgrades != 'undefined' && !course.showgrades) {
+            if (course && typeof course.showgrades != 'undefined' && course.showgrades == 0) {
                 return false;
             }
             return true;

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ angular.module('mm.addons.coursecompletion')`
`176`	`176`	`}`
`177`	`177`
`178`	`178`	`return $mmCourses.getUserCourse(courseId, true).then(function(course) {`
`179`		`- if (course && typeof course.enablecompletion != 'undefined' && !course.enablecompletion) {`
	`179`	`+ if (course && typeof course.enablecompletion != 'undefined' && course.enablecompletion == 0) {`
`180`	`180`	`return false;`
`181`	`181`	`}`
`182`	`182`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -217,7 +217,7 @@ angular.module('mm.addons.grades')`
`217`	`217`	`}`
`218`	`218`
`219`	`219`	`return $mmCourses.getUserCourse(courseId, true, siteId).then(function(course) {`
`220`		`- if (course && typeof course.showgrades != 'undefined' && !course.showgrades) {`
	`220`	`+ if (course && typeof course.showgrades != 'undefined' && course.showgrades == 0) {`
`221`	`221`	`return false;`
`222`	`222`	`}`
`223`	`223`	`return true;`