Skip to content

Commit 4de906c

Browse files
committed
MOBILE-2103 feedback: Pre-process page only online
1 parent 42c6cfa commit 4de906c

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

www/addons/mod/feedback/services/feedback.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,8 +566,10 @@ angular.module('mm.addons.mod_feedback')
566566
return self.getCurrentValues(feedbackId, offline, ignoreCache, siteId).then(function(valuesArray) {
567567
if (valuesArray.length == 0) {
568568
// Try sending empty values to get the last completed attempt values.
569-
return self.processPage(feedbackId, 0, {}).then(function() {
569+
return self.processPageOnline(feedbackId, 0, {}, undefined, siteId).then(function() {
570570
return self.getCurrentValues(feedbackId, offline, ignoreCache, siteId);
571+
}).catch(function() {
572+
// Ignore errors
571573
});
572574
}
573575
return valuesArray;

www/addons/mod/feedback/services/prefetch_handler.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ angular.module('mm.addons.mod_feedback')
237237

238238
if (accessData.cancomplete && accessData.cansubmit && !accessData.isempty) {
239239
// Send empty data, so it will recover last completed feedback attempt values.
240-
p2.push($mmaModFeedback.processPage(feedback.id, 0, {}, undefined, undefined, undefined, siteId).finally(function() {
240+
p2.push($mmaModFeedback.processPageOnline(feedback.id, 0, {}, undefined, siteId).finally(function() {
241241
var p4 = [];
242242

243243
p4.push($mmaModFeedback.getCurrentValues(feedback.id, false, true, siteId));

0 commit comments

Comments
 (0)