Skip to content

Commit 5971969

Browse files
authored
Merge pull request #1826 from dpalou/MOBILE-2915
Mobile 2915
2 parents 6e1e99f + ceff885 commit 5971969

File tree

5 files changed

+21
-20
lines changed

5 files changed

+21
-20
lines changed

src/addon/blog/components/entries/entries.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -135,9 +135,7 @@ export class AddonBlogEntriesComponent implements OnInit {
135135
this.canLoadMore = result.totalentries > this.entries.length;
136136
this.pageLoaded++;
137137

138-
this.showMyIssuesToggle = !this.userId && (this.showMyIssuesToggle || this.entries.some((entry) => {
139-
return entry.userid == this.currentUserId;
140-
}));
138+
this.showMyIssuesToggle = !this.userId;
141139

142140
return Promise.all(promises);
143141
}).catch((message) => {

src/addon/messages/components/discussions/discussions.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,8 @@ export class AddonMessagesDiscussionsComponent implements OnDestroy {
9292
discussion.unread = false;
9393

9494
// Conversations changed, invalidate them and refresh unread counts.
95-
this.messagesProvider.invalidateConversations();
96-
this.messagesProvider.refreshUnreadConversationCounts();
95+
this.messagesProvider.invalidateConversations(this.siteId);
96+
this.messagesProvider.refreshUnreadConversationCounts(this.siteId);
9797
}
9898
}
9999
}, this.siteId);
@@ -145,10 +145,10 @@ export class AddonMessagesDiscussionsComponent implements OnDestroy {
145145
*/
146146
refreshData(refresher?: any, refreshUnreadCounts: boolean = true): Promise<any> {
147147
const promises = [];
148-
promises.push(this.messagesProvider.invalidateDiscussionsCache());
148+
promises.push(this.messagesProvider.invalidateDiscussionsCache(this.siteId));
149149

150150
if (refreshUnreadCounts) {
151-
promises.push(this.messagesProvider.invalidateUnreadConversationCounts());
151+
promises.push(this.messagesProvider.invalidateUnreadConversationCounts(this.siteId));
152152
}
153153

154154
return this.utils.allPromises(promises).finally(() => {
@@ -171,7 +171,7 @@ export class AddonMessagesDiscussionsComponent implements OnDestroy {
171171

172172
const promises = [];
173173

174-
promises.push(this.messagesProvider.getDiscussions().then((discussions) => {
174+
promises.push(this.messagesProvider.getDiscussions(this.siteId).then((discussions) => {
175175
// Convert to an array for sorting.
176176
const discussionsSorted = [];
177177
for (const userId in discussions) {
@@ -184,7 +184,7 @@ export class AddonMessagesDiscussionsComponent implements OnDestroy {
184184
});
185185
}));
186186

187-
promises.push(this.messagesProvider.getUnreadConversationCounts());
187+
promises.push(this.messagesProvider.getUnreadConversationCounts(this.siteId));
188188

189189
return Promise.all(promises).catch((error) => {
190190
this.domUtils.showErrorModalDefault(error, 'addon.messages.errorwhileretrievingdiscussions', true);
@@ -216,7 +216,7 @@ export class AddonMessagesDiscussionsComponent implements OnDestroy {
216216
this.loaded = false;
217217
this.loadingMessage = this.search.loading;
218218

219-
return this.messagesProvider.searchMessages(query).then((searchResults) => {
219+
return this.messagesProvider.searchMessages(query, undefined, undefined, undefined, this.siteId).then((searchResults) => {
220220
this.search.showResults = true;
221221
this.search.results = searchResults.messages;
222222
}).catch((error) => {

src/core/login/pages/init/init.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,8 @@ export class CoreLoginInitPage {
5555
.then((loggedIn) => {
5656

5757
if (loggedIn) {
58-
return this.navCtrl.setRoot(redirectData.page, redirectData.params, { animate: false });
58+
return this.loginHelper.goToSiteInitialPage(this.navCtrl, redirectData.page, redirectData.params,
59+
{ animate: false });
5960
}
6061
}).catch(() => {
6162
// Site doesn't exist.

src/core/login/pages/reconnect/reconnect.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -146,12 +146,8 @@ export class CoreLoginReconnectPage {
146146
// Reset fields so the data is not in the view anymore.
147147
this.credForm.controls['password'].reset();
148148

149-
if (this.pageName) {
150-
// Page defined, go to that page instead of site initial page.
151-
return this.navCtrl.setRoot(this.pageName, this.pageParams);
152-
} else {
153-
return this.loginHelper.goToSiteInitialPage();
154-
}
149+
// Go to the site initial page.
150+
return this.loginHelper.goToSiteInitialPage(this.navCtrl, this.pageName, this.pageParams);
155151
}).catch((error) => {
156152
// Error, go back to login page.
157153
this.domUtils.showErrorModalDefault(error, 'core.login.errorupdatesite', true);

src/core/login/providers/helper.ts

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
import { Injectable } from '@angular/core';
1616
import { Location } from '@angular/common';
17-
import { Platform, AlertController } from 'ionic-angular';
17+
import { Platform, AlertController, NavController, NavOptions } from 'ionic-angular';
1818
import { TranslateService } from '@ngx-translate/core';
1919
import { CoreAppProvider } from '@providers/app';
2020
import { CoreConfigProvider } from '@providers/config';
@@ -416,14 +416,20 @@ export class CoreLoginHelperProvider {
416416
/**
417417
* Go to the initial page of a site depending on 'userhomepage' setting.
418418
*
419+
* @param {NavController} [navCtrl] NavController to use. Defaults to app root NavController.
420+
* @param {string} [page] Name of the page to load after loading the main page.
421+
* @param {any} [params] Params to pass to the page.
422+
* @param {NavOptions} [options] Navigation options.
419423
* @return {Promise<any>} Promise resolved when done.
420424
*/
421-
goToSiteInitialPage(): Promise<any> {
425+
goToSiteInitialPage(navCtrl?: NavController, page?: string, params?: any, options?: NavOptions): Promise<any> {
426+
navCtrl = navCtrl || this.appProvider.getRootNavController();
427+
422428
// Due to DeepLinker, we need to remove the path from the URL before going to main menu.
423429
// IonTabs checks the URL to determine which path to load for deep linking, so we clear the URL.
424430
this.location.replaceState('');
425431

426-
return this.appProvider.getRootNavController().setRoot('CoreMainMenuPage');
432+
return navCtrl.setRoot('CoreMainMenuPage', { redirectPage: page, redirectParams: params }, options);
427433
}
428434

429435
/**

0 commit comments

Comments
 (0)