MOBILE-1447 media: Fix problem with source without type

dpalou · dpalou · commit 82a04fd24a93 · 2016-03-01T12:08:45.000+01:00
diff --git a/www/core/directives/external_content.js b/www/core/directives/external_content.js
@@ -45,9 +45,12 @@ angular.module('mm.core')
             return;
         }
 
-        var e = document.createElement('source');
+        var e = document.createElement('source'),
+            type = dom.getAttribute('type');
         e.setAttribute('src', url);
-        e.setAttribute('type', dom.getAttribute('type'));
+        if (type) {
+            e.setAttribute('type', type);
+        }
         dom.parentNode.insertBefore(e, dom);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -45,9 +45,12 @@ angular.module('mm.core')`
`45`	`45`	`return;`
`46`	`46`	`}`
`47`	`47`
`48`		`- var e = document.createElement('source');`
	`48`	`+ var e = document.createElement('source'),`
	`49`	`+ type = dom.getAttribute('type');`
`49`	`50`	`e.setAttribute('src', url);`
`50`		`- e.setAttribute('type', dom.getAttribute('type'));`
	`51`	`+ if (type) {`
	`52`	`+ e.setAttribute('type', type);`
	`53`	`+ }`
`51`	`54`	`dom.parentNode.insertBefore(e, dom);`
`52`	`55`	`}`
`53`	`56`