MOBILE-4759 core: Remove most modules for components and directives

Author: dpalou

src/core/components/components.module.ts

@@ -57,11 +57,11 @@ import { CoreCourseImageComponent } from '@components/course-image/course-image'
 import { CoreSitesListComponent } from './sites-list/sites-list';
 
 /**
- * Get standalone components for site plugins.
+ * Get deprecated components for site plugins.
  *
- * @returns Returns core standalone components.
+ * @returns Returns core deprecated components.
  */
-export async function getCoreStandaloneComponents(): Promise<Type<unknown>[]> {
+export async function getCoreDeprecatedComponents(): Promise<Type<unknown>[]> {
     // eslint-disable-next-line deprecation/deprecation
     const { CoreStyleComponent } = await import('@components/style/style');
     // eslint-disable-next-line deprecation/deprecation

src/core/features/block/block.module.ts

@@ -29,5 +29,20 @@ export async function getBlockServices(): Promise<Type<unknown>[]> {
     ];
 }
 
+/**
+ * Get directives and components for site plugins.
+ *
+ * @returns Returns directives and components.
+ */
+export async function getBlockExportedDirectives(): Promise<Type<unknown>[]> {
+    const { CoreBlockComponent } = await import('@features/block/components/block/block');
+    const { CoreBlockSideBlocksButtonComponent } = await import('@features/block/components/side-blocks-button/side-blocks-button');
+
+    return [
+        CoreBlockComponent,
+        CoreBlockSideBlocksButtonComponent,
+    ];
+}
+
 @NgModule({})
 export class CoreBlockModule {}

src/core/features/block/components/components.module.ts

@@ -41,14 +41,16 @@ import { CoreEvents } from '@singletons/events';
 import { makeSingleton } from '@singletons';
 import { effectWithInjectionContext, modelWithInjectionContext } from '@/core/utils/signals';
 
-// Import core services.
+// Import core services and exported directives/objects.
+import { CoreSharedModule } from '@/core/shared.module';
+import { getCoreDeprecatedComponents } from '@components/components.module';
 import { getCoreExportedObjects, getCoreServices } from '@/core/core.module';
-import { getBlockServices } from '@features/block/block.module';
+import { getBlockExportedDirectives, getBlockServices } from '@features/block/block.module';
 import { getCommentsServices } from '@features/comments/comments.module';
 import { getContentLinksExportedObjects, getContentLinksServices } from '@features/contentlinks/contentlinks.module';
-import { getCourseExportedObjects, getCourseServices, getCourseStandaloneComponents } from '@features/course/course.module';
-import { getCoursesExportedObjects, getCoursesServices } from '@features/courses/courses.module';
-import { getEditorServices } from '@features/editor/editor.module';
+import { getCourseExportedObjects, getCourseServices, getCourseExportedDirectives } from '@features/course/course.module';
+import { getCoursesExportedDirectives, getCoursesExportedObjects, getCoursesServices } from '@features/courses/courses.module';
+import { getEditorExportedDirectives, getEditorServices } from '@features/editor/editor.module';
 import { getEnrolServices } from '@features/enrol/enrol.module';
 import { getFileUploadedServices } from '@features/fileuploader/fileuploader.module';
 import { getFilterServices } from '@features/filter/filter.module';
@@ -58,15 +60,16 @@ import { getLoginServices } from '@features/login/login.module';
 import { getMainMenuExportedObjects, getMainMenuServices } from '@features/mainmenu/mainmenu.module';
 import { getNativeServices } from '@features/native/native.module';
 import { getPushNotificationsServices } from '@features/pushnotifications/pushnotifications.module';
-import { getQuestionServices } from '@features/question/question.module';
+import { getQuestionExportedDirectives, getQuestionServices } from '@features/question/question.module';
 import { getRatingServices } from '@features/rating/rating.module';
-import { getSearchServices } from '@features/search/search.module';
+import { getRemindersExportedDirectives, getRemindersServices } from '@features/reminders/reminders.module';
+import { getSearchExportedDirectives, getSearchServices } from '@features/search/search.module';
 import { getSettingsServices } from '@features/settings/settings.module';
 import { getSharedFilesServices } from '@features/sharedfiles/sharedfiles.module';
 import { getSiteHomeServices } from '@features/sitehome/sitehome.module';
 import { getStyleServices } from '@features/styles/styles.module';
 import { getTagServices } from '@features/tag/tag.module';
-import { getUsersServices } from '@features/user/user.module';
+import { getUsersExportedDirectives, getUsersServices } from '@features/user/user.module';
 import { getXAPIServices } from '@features/xapi/xapi.module';
 
 // Import other libraries and providers.
@@ -104,17 +107,6 @@ import { CoreWait } from '@singletons/wait';
 import { CoreWindow } from '@singletons/window';
 import { getCoreErrorsExportedObjects } from '@classes/errors/errors';
 
-// Import all core modules that define components, directives and pipes.
-import { CoreSharedModule } from '@/core/shared.module';
-import { CoreCourseComponentsModule } from '@features/course/components/components.module';
-import { CoreCourseDirectivesModule } from '@features/course/directives/directives.module';
-import { CoreCoursesComponentsModule } from '@features/courses/components/components.module';
-import { CoreUserComponentsModule } from '@features/user/components/components.module';
-import { CoreQuestionComponentsModule } from '@features/question/components/components.module';
-import { CoreBlockComponentsModule } from '@features/block/components/components.module';
-import { CoreEditorComponentsModule } from '@features/editor/components/components.module';
-import { CoreSearchComponentsModule } from '@features/search/components/components.module';
-
 // Import addon providers. Do not import database module because it causes circular dependencies.
 import { getBadgesServices } from '@addons/badges/badges.module';
 import { getCalendarServices } from '@addons/calendar/calendar.module';
@@ -129,16 +121,13 @@ import { getNotesServices } from '@addons/notes/notes.module';
 import { getNotificationsServices } from '@addons/notifications/notifications.module';
 import { getPrivateFilesServices } from '@addons/privatefiles/privatefiles.module';
 
-// Import standalone components used by site plugins.
-import { getCoreStandaloneComponents } from '@components/components.module';
-
 // Import some addon modules that define components, directives and pipes. Only import the important ones.
 import { CorePromisedValue } from '@classes/promised-value';
 import { CorePlatform } from '@services/platform';
 
 import { CoreAutoLogoutService } from '@features/autologout/services/autologout';
 import {
-    getSitePluginsDirectives,
+    getSitePluginsExportedDirectives,
     getSitePluginsExportedObjects,
     getSitePluginsServices,
 } from '@features/siteplugins/siteplugins.module';
@@ -161,20 +150,19 @@ export class CoreCompileProvider {
     // List of imports for dynamic module. Since the template can have any component we need to import all core components modules.
     protected readonly IMPORTS = [
         CoreSharedModule,
-        CoreCourseComponentsModule,
-        CoreCoursesComponentsModule,
-        CoreUserComponentsModule,
-        CoreCourseDirectivesModule,
-        CoreQuestionComponentsModule,
-        CoreBlockComponentsModule,
-        CoreEditorComponentsModule,
-        CoreSearchComponentsModule,
     ];
 
     protected readonly LAZY_IMPORTS = [
-        getCoreStandaloneComponents,
-        getCourseStandaloneComponents,
-        getSitePluginsDirectives,
+        getBlockExportedDirectives,
+        getCoreDeprecatedComponents,
+        getCourseExportedDirectives,
+        getCoursesExportedDirectives,
+        getEditorExportedDirectives,
+        getQuestionExportedDirectives,
+        getRemindersExportedDirectives,
+        getSearchExportedDirectives,
+        getSitePluginsExportedDirectives,
+        getUsersExportedDirectives,
     ];
 
     protected componentId = 0;
@@ -408,6 +396,7 @@ export class CoreCompileProvider {
             getNotesServices(),
             getNotificationsServices(),
             getPrivateFilesServices(),
+            getRemindersServices(),
             getSitePluginsServices(),
         ]);
 

src/core/features/compile/services/compile.ts

@@ -79,17 +79,21 @@ export async function getCourseExportedObjects(): Promise<Record<string, unknown
         CORE_COURSE_COMPONENT,
         CORE_COURSE_CORE_MODULES,
     } = await import('@features/course/constants');
+
+    // Export components that are used from JS code instead of in templates. E.g. when opening a modal or in a handler.
     const { CoreCourseUnsupportedModuleComponent } =
         await import ('@features/course/components/unsupported-module/unsupported-module');
     const { CoreCourseFormatSingleActivityComponent } =
         await import ('@features/course/format/singleactivity/components/singleactivity');
+    const { CoreCourseCourseIndexComponent } = await import('@features/course/components/course-index/course-index');
 
     /* eslint-disable @typescript-eslint/naming-convention */
     return {
         CoreCourseActivityPrefetchHandlerBase,
         CoreCourseResourcePrefetchHandlerBase,
         CoreCourseUnsupportedModuleComponent,
         CoreCourseFormatSingleActivityComponent,
+        CoreCourseCourseIndexComponent,
         CoreCourseAccessDataType,
         CORE_COURSE_ALL_SECTIONS_ID,
         CORE_COURSE_STEALTH_MODULES_SECTION_ID,
@@ -102,24 +106,40 @@ export async function getCourseExportedObjects(): Promise<Record<string, unknown
 }
 
 /**
- * Get standalone components for site plugins.
+ * Get directives and components for site plugins.
  *
- * @returns Returns standalone components.
+ * @returns Returns directives and components.
  */
-export async function getCourseStandaloneComponents(): Promise<Type<unknown>[]> {
+export async function getCourseExportedDirectives(): Promise<Type<unknown>[]> {
+    const { CoreCourseFormatComponent } = await import('@features/course/components/course-format/course-format');
+    const { CoreCourseSectionComponent } = await import('@features/course/components/course-section/course-section');
+    const { CoreCourseModuleComponent } = await import('@features/course/components/module/module');
+    const { CoreCourseModuleCompletionComponent } = await import('@features/course/components/module-completion/module-completion');
+    const { CoreCourseModuleCompletionLegacyComponent } =
+        await import('@features/course/components/module-completion-legacy/module-completion-legacy');
+    const { CoreCourseModuleInfoComponent } = await import('@features/course/components/module-info/module-info');
+    const { CoreCourseModuleNavigationComponent } = await import('@features/course/components/module-navigation/module-navigation');
+
+    const { CoreCourseDownloadModuleMainFileDirective } = await import('@features/course/directives/download-module-main-file');
+
     // eslint-disable-next-line deprecation/deprecation
     const { CoreCourseModuleDescriptionComponent } =
         await import('@features/course/components/module-description/module-description');
     // eslint-disable-next-line deprecation/deprecation
     const { CoreCourseModuleManualCompletionComponent } =
         await import('@features/course/components/module-manual-completion/module-manual-completion');
-    const { CoreCourseFormatComponent } =
-        await import('@features/course/components/course-format/course-format');
 
     return [
         CoreCourseModuleDescriptionComponent,
         CoreCourseModuleManualCompletionComponent,
         CoreCourseFormatComponent,
+        CoreCourseSectionComponent,
+        CoreCourseModuleComponent,
+        CoreCourseModuleCompletionComponent,
+        CoreCourseModuleCompletionLegacyComponent,
+        CoreCourseModuleInfoComponent,
+        CoreCourseModuleNavigationComponent,
+        CoreCourseDownloadModuleMainFileDirective,
     ];
 }
 

src/core/features/course/components/components.module.ts

@@ -88,6 +88,19 @@ export async function getCoursesExportedObjects(): Promise<Record<string, unknow
     /* eslint-enable @typescript-eslint/naming-convention */
 }
 
+/**
+ * Get directives and components for site plugins.
+ *
+ * @returns Returns directives and components.
+ */
+export async function getCoursesExportedDirectives(): Promise<Type<unknown>[]> {
+    const { CoreCoursesCourseListItemComponent } = await import('@features/courses/components/course-list-item/course-list-item');
+
+    return [
+        CoreCoursesCourseListItemComponent,
+    ];
+}
+
 const mainMenuHomeChildrenRoutes: Routes = [
     {
         path: CoreDashboardHomeHandlerService.PAGE_NAME,