Merge pull request #4524 from crazyserver/MOBILE-4842

MOBILE-4842 myoverview: Fix combobox selection output model

Author: dpalou

src/addons/block/myoverview/components/myoverview/addon-block-myoverview.html

@@ -37,7 +37,7 @@ <h2>{{ 'addon.block_myoverview.pluginname' | translate }}</h2>
         <ion-row class="ion-justify-content-between ion-align-items-center addon-block-myoverview-filter">
             @if (filters.enabled) {
                 <ion-col size="auto">
-                    <core-combobox [label]="'core.courses.filtermycourses' | translate" [selection]="filters.timeFilterSelected"
+                    <core-combobox [label]="'core.courses.filtermycourses' | translate" [(selection)]="filters.timeFilterSelected"
                         (selectionChange)="filterCourses()">
                         @if (filters.show.allincludinghidden) {
                             <ion-select-option class="ion-text-wrap core-select-option-border-bottom" value="allincludinghidden">
@@ -95,7 +95,7 @@ <h2>{{ 'addon.block_myoverview.pluginname' | translate }}</h2>
             </ion-col>
             @if (sort.enabled) {
                 <ion-col size="auto">
-                    <core-combobox [label]="'core.sortby' | translate" [selection]="sort.selected" (selectionChange)="sortCourses()"
+                    <core-combobox [label]="'core.sortby' | translate" [(selection)]="sort.selected" (selectionChange)="sortCourses()"
                         icon="fas-arrow-down-short-wide" class="no-border">
                         <ion-select-option class="ion-text-wrap" value="fullname">
                             {{'addon.block_myoverview.title' | translate}}

src/core/components/combobox/combobox.ts

@@ -135,13 +135,14 @@ export class CoreComboboxComponent implements ControlValueAccessor {
 
         this.expanded.set(true);
 
-        const data = await CoreModals.openModal({
+        const data = await CoreModals.openModal<string>({
             ...modalOptions,
             id: this.listboxId() || modalOptions.id,
         });
         this.expanded.set(false);
 
         if (data) {
+            this.selection.set(data);
             this.onValueChanged(data);
         }
     }