MOBILE-4948 pipe: Recalculate value if any changes on coreTimeAgo

Author: crazyserver

src/core/pipes/seconds-to-hms.ts

@@ -38,6 +38,7 @@ export class CoreSecondsToHMSPipe implements PipeTransform {
      * Convert a number of seconds to Hours:Minutes:Seconds.
      *
      * @param seconds Number of seconds.
+     * @param showHours Whether to always show hours (even if 0).
      * @returns Formatted seconds.
      */
     transform(seconds: string | number, showHours = true): string {

src/core/pipes/time-ago.ts

@@ -12,32 +12,61 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import { Pipe, PipeTransform } from '@angular/core';
+import { Pipe, PipeTransform, OnDestroy } from '@angular/core';
 import { Translate } from '@singletons';
 import { CoreLogger } from '@static/logger';
 import { dayjs } from '@/core/utils/dayjs';
+import { Subscription } from 'rxjs';
 
 /**
  * Pipe to turn a UNIX timestamp to "time ago".
  */
 @Pipe({
     name: 'coreTimeAgo',
+    pure: false,
 })
-export class CoreTimeAgoPipe implements PipeTransform {
+export class CoreTimeAgoPipe implements PipeTransform, OnDestroy {
 
-    private logger: CoreLogger;
+    protected logger: CoreLogger;
+    protected cachedResult?: string;
+    protected subscription: Subscription;
+
+    protected lastTimestamp?: number | string;
 
     constructor() {
         this.logger = CoreLogger.getInstance('CoreTimeAgoPipe');
+
+        this.subscription = Translate.onLangChange.subscribe(() => {
+            this.cachedResult = undefined;
+        });
     }
 
     /**
-     * Turn a UNIX timestamp to "time ago".
+     * Pipes a timestamp into a "time ago" format.
      *
      * @param timestamp The UNIX timestamp (without milliseconds).
      * @returns Formatted time.
      */
     transform(timestamp: string | number): string {
+        if (this.lastTimestamp !== timestamp) {
+            this.lastTimestamp = timestamp;
+            this.cachedResult = undefined;
+        }
+
+        if (this.cachedResult === undefined) {
+            this.cachedResult = this.formatTimeAgo(timestamp);
+        }
+
+        return this.cachedResult;
+    }
+
+    /**
+     * Turn a UNIX timestamp to "time ago".
+     *
+     * @param timestamp The UNIX timestamp (without milliseconds).
+     * @returns Formatted time.
+     */
+    protected formatTimeAgo(timestamp: string | number): string {
         if (typeof timestamp === 'string') {
             // Convert the value to a number.
             const numberTimestamp = parseInt(timestamp, 10);
@@ -52,4 +81,11 @@ export class CoreTimeAgoPipe implements PipeTransform {
         return Translate.instant('core.ago', { $a: dayjs(timestamp * 1000).fromNow(true) });
     }
 
+    /**
+     * @inheritdoc
+     */
+    ngOnDestroy(): void {
+        this.subscription.unsubscribe();
+    }
+
 }