Skip to content

Commit 90fecde

Browse files
authored
Merge pull request #2251 from crazyserver/MOBILE-3314
MOBILE-3314 assign: Check grade access before prefetch
2 parents 7427738 + d3718c0 commit 90fecde

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/addon/mod/assign/providers/prefetch-handler.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,11 @@ export class AddonModAssignPrefetchHandler extends CoreCourseActivityPrefetchHan
443443

444444
// Prefetch grade items.
445445
if (userId) {
446-
promises.push(this.gradesHelper.getGradeModuleItems(courseId, moduleId, userId, undefined, siteId, true));
446+
promises.push(this.courseProvider.getModuleBasicGradeInfo(moduleId, siteId).then((gradeInfo) => {
447+
if (gradeInfo) {
448+
promises.push(this.gradesHelper.getGradeModuleItems(courseId, moduleId, userId, undefined, siteId, true));
449+
}
450+
}));
447451
}
448452

449453
// Prefetch feedback.

src/addon/mod/wiki/providers/prefetch-handler.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ import { CoreGroupsProvider } from '@providers/groups';
2424
import { CoreTextUtilsProvider } from '@providers/utils/text';
2525
import { CoreCourseActivityPrefetchHandlerBase } from '@core/course/classes/activity-prefetch-handler';
2626
import { CoreCourseHelperProvider } from '@core/course/providers/helper';
27-
import { CoreGradesHelperProvider } from '@core/grades/providers/helper';
2827
import { CoreUserProvider } from '@core/user/providers/user';
2928
import { AddonModWikiProvider } from './wiki';
3029
import { AddonModWikiSyncProvider } from './wiki-sync';
@@ -55,7 +54,6 @@ export class AddonModWikiPrefetchHandler extends CoreCourseActivityPrefetchHandl
5554
protected textUtils: CoreTextUtilsProvider,
5655
protected courseHelper: CoreCourseHelperProvider,
5756
protected groupsProvider: CoreGroupsProvider,
58-
protected gradesHelper: CoreGradesHelperProvider,
5957
protected syncProvider: AddonModWikiSyncProvider) {
6058

6159
super(translate, appProvider, utils, courseProvider, filepoolProvider, sitesProvider, domUtils, filterHelper,

0 commit comments

Comments
 (0)