Skip to content

Commit 9b1144a

Browse files
authored
Merge pull request #2271 from crazyserver/MOBILE-3281
Mobile 3281
2 parents a909e13 + c3950ba commit 9b1144a

File tree

23 files changed

+521
-107
lines changed

23 files changed

+521
-107
lines changed

src/addon/messages/components/components.module.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import { TranslateModule } from '@ngx-translate/core';
1919
import { CoreComponentsModule } from '@components/components.module';
2020
import { CoreDirectivesModule } from '@directives/directives.module';
2121
import { CorePipesModule } from '@pipes/pipes.module';
22+
import { CoreSearchComponentsModule } from '@core/search/components/components.module';
2223
import { AddonMessagesDiscussionsComponent } from '../components/discussions/discussions';
2324
import { AddonMessagesConfirmedContactsComponent } from '../components/confirmed-contacts/confirmed-contacts';
2425
import { AddonMessagesContactRequestsComponent } from '../components/contact-requests/contact-requests';
@@ -37,7 +38,8 @@ import { AddonMessagesContactsComponent } from '../components/contacts/contacts'
3738
TranslateModule.forChild(),
3839
CoreComponentsModule,
3940
CoreDirectivesModule,
40-
CorePipesModule
41+
CorePipesModule,
42+
CoreSearchComponentsModule,
4143
],
4244
providers: [
4345
],

src/addon/messages/components/contacts/addon-messages-contacts.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<ion-refresher-content pullingText="{{ 'core.pulltorefresh' | translate }}"></ion-refresher-content>
44
</ion-refresher>
55

6-
<core-search-box (onSubmit)="search($event)" (onClear)="clearSearch($event)" [placeholder]=" 'addon.messages.contactname' | translate" autocorrect="off" spellcheck="false" lengthCheck="2" [disabled]="!loaded"></core-search-box>
6+
<core-search-box (onSubmit)="search($event)" (onClear)="clearSearch($event)" [placeholder]=" 'addon.messages.contactname' | translate" autocorrect="off" spellcheck="false" lengthCheck="2" [disabled]="!loaded" searchArea="AddonMessagesContacts"></core-search-box>
77

88
<core-loading [hideUntil]="loaded" [message]="loadingMessage">
99
<core-empty-box *ngIf="!hasContacts && searchString == ''" icon="person" [message]="'addon.messages.contactlistempty' | translate"></core-empty-box>

src/addon/messages/components/discussions/addon-messages-discussions.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<ion-refresher-content pullingText="{{ 'core.pulltorefresh' | translate }}"></ion-refresher-content>
44
</ion-refresher>
55

6-
<core-search-box *ngIf="search.enabled" (onSubmit)="searchMessage($event)" (onClear)="clearSearch($event)" [placeholder]=" 'addon.messages.message' | translate" autocorrect="off" spellcheck="false" lengthCheck="2" [disabled]="!loaded"></core-search-box>
6+
<core-search-box *ngIf="search.enabled" (onSubmit)="searchMessage($event)" (onClear)="clearSearch($event)" [placeholder]=" 'addon.messages.message' | translate" autocorrect="off" spellcheck="false" lengthCheck="2" [disabled]="!loaded" searchArea="AddonMessagesDiscussions"></core-search-box>
77

88
<core-loading [hideUntil]="loaded" [message]="loadingMessage">
99

src/addon/messages/pages/search/search.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
</ion-header>
1010
<core-split-view>
1111
<ion-content>
12-
<core-search-box (onSubmit)="search($event)" (onClear)="clearSearch($event)" [disabled]="disableSearch" autocorrect="off" [spellcheck]="false" [autoFocus]="true" [lengthCheck]="1"></core-search-box>
12+
<core-search-box (onSubmit)="search($event)" (onClear)="clearSearch($event)" [disabled]="disableSearch" autocorrect="off" [spellcheck]="false" [autoFocus]="true" [lengthCheck]="1" searchArea="AddonMessagesSearch"></core-search-box>
1313
<core-loading [hideUntil]="!displaySearching" [message]="'core.searching' | translate">
1414
<ion-list *ngIf="displayResults">
1515
<ng-container *ngTemplateOutlet="resultsTemplate; context: {item: contacts}"></ng-container>

src/addon/messages/pages/search/search.module.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import { AddonMessagesSearchPage } from './search';
1919
import { CoreComponentsModule } from '@components/components.module';
2020
import { CoreDirectivesModule } from '@directives/directives.module';
2121
import { CorePipesModule } from '@pipes/pipes.module';
22+
import { CoreSearchComponentsModule } from '@core/search/components/components.module';
2223
import { AddonMessagesComponentsModule } from '../../components/components.module';
2324

2425
@NgModule({
@@ -29,9 +30,10 @@ import { AddonMessagesComponentsModule } from '../../components/components.modul
2930
CoreComponentsModule,
3031
CoreDirectivesModule,
3132
CorePipesModule,
33+
CoreSearchComponentsModule,
3234
AddonMessagesComponentsModule,
3335
IonicPageModule.forChild(AddonMessagesSearchPage),
34-
TranslateModule.forChild()
36+
TranslateModule.forChild(),
3537
],
3638
})
3739
export class AddonMessagesSearchPageModule {}

src/addon/mod/glossary/components/components.module.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import { CoreComponentsModule } from '@components/components.module';
2020
import { CoreDirectivesModule } from '@directives/directives.module';
2121
import { CorePipesModule } from '@pipes/pipes.module';
2222
import { CoreCourseComponentsModule } from '@core/course/components/components.module';
23+
import { CoreSearchComponentsModule } from '@core/search/components/components.module';
2324
import { AddonModGlossaryIndexComponent } from './index/index';
2425
import { AddonModGlossaryModePickerPopoverComponent } from './mode-picker/mode-picker';
2526

@@ -35,7 +36,8 @@ import { AddonModGlossaryModePickerPopoverComponent } from './mode-picker/mode-p
3536
CoreComponentsModule,
3637
CoreDirectivesModule,
3738
CorePipesModule,
38-
CoreCourseComponentsModule
39+
CoreCourseComponentsModule,
40+
CoreSearchComponentsModule,
3941
],
4042
providers: [
4143
],

src/addon/mod/glossary/components/index/addon-mod-glossary-index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
<ion-icon name="warning"></ion-icon> {{ 'core.hasdatatosync' | translate:{$a: moduleName} }}
3030
</ion-card>
3131

32-
<core-search-box *ngIf="viewMode == 'search'" (onSubmit)="search($event)" [placeholder]="'addon.mod_glossary.searchquery' | translate" [autoFocus]="true" [lengthCheck]="2" [showClear]="false"></core-search-box>
32+
<core-search-box *ngIf="viewMode == 'search'" (onSubmit)="search($event)" [placeholder]="'addon.mod_glossary.searchquery' | translate" [autoFocus]="true" [lengthCheck]="2" [showClear]="false" searchArea="AddonModGlossary-{{module.id}}"></core-search-box>
3333

3434
<core-loading [hideUntil]="loaded" class="core-loading-center">
3535

src/app/app.module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ import { CoreRatingModule } from '@core/rating/rating.module';
8787
import { CoreTagModule } from '@core/tag/tag.module';
8888
import { CoreFilterModule } from '@core/filter/filter.module';
8989
import { CoreH5PModule } from '@core/h5p/h5p.module';
90+
import { CoreSearchModule } from '@core/search/search.module';
9091

9192
// Addon modules.
9293
import { AddonBadgesModule } from '@addon/badges/badges.module';
@@ -235,6 +236,7 @@ export const WP_PROVIDER: any = null;
235236
CoreTagModule,
236237
CoreFilterModule,
237238
CoreH5PModule,
239+
CoreSearchModule,
238240
AddonBadgesModule,
239241
AddonBlogModule,
240242
AddonCalendarModule,

src/app/app.scss

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,15 @@ ion-app.app-root {
112112
@include core-selected-item($core-splitview-selected);
113113
}
114114

115-
// Recover borders on items inside cards.
115+
// Recover borders on items inside cards and lists.
116116
.card.with-borders .core-as-item,
117+
.list.with-borders .core-as-item,
117118
.core-as-item {
118119
@include core-as-items();
119120
}
120121

121-
.card.with-borders .item {
122+
.card.with-borders .item,
123+
.list.with-borders .item {
122124
@include core-items();
123125
}
124126

src/components/components.module.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ import { CoreSplitViewComponent } from './split-view/split-view';
2525
import { CoreIframeComponent } from './iframe/iframe';
2626
import { CoreProgressBarComponent } from './progress-bar/progress-bar';
2727
import { CoreEmptyBoxComponent } from './empty-box/empty-box';
28-
import { CoreSearchBoxComponent } from './search-box/search-box';
2928
import { CoreFileComponent } from './file/file';
3029
import { CoreFilesComponent } from './files/files';
3130
import { CoreIconComponent } from './icon/icon';
@@ -66,7 +65,6 @@ import { CoreBSTooltipComponent } from './bs-tooltip/bs-tooltip';
6665
CoreIframeComponent,
6766
CoreProgressBarComponent,
6867
CoreEmptyBoxComponent,
69-
CoreSearchBoxComponent,
7068
CoreFileComponent,
7169
CoreFilesComponent,
7270
CoreIconComponent,
@@ -118,7 +116,6 @@ import { CoreBSTooltipComponent } from './bs-tooltip/bs-tooltip';
118116
CoreIframeComponent,
119117
CoreProgressBarComponent,
120118
CoreEmptyBoxComponent,
121-
CoreSearchBoxComponent,
122119
CoreFileComponent,
123120
CoreFilesComponent,
124121
CoreIconComponent,

0 commit comments

Comments
 (0)