Skip to content

Commit a1b557d

Browse files
authored
Merge pull request #2419 from dpalou/MOBILE-3401
MOBILE-3401 login: Fix navigation when authenticate via URL scheme
2 parents 2a2e3af + 112377c commit a1b557d

File tree

2 files changed

+9
-2
lines changed

2 files changed

+9
-2
lines changed

src/core/login/providers/helper.ts

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -531,9 +531,16 @@ export class CoreLoginHelperProvider {
531531
goToNoSitePage(navCtrl: NavController, page: string, params?: any): Promise<any> {
532532
navCtrl = navCtrl || this.appProvider.getRootNavController();
533533

534-
if (page == 'CoreLoginSitesPage') {
534+
const currentPage = navCtrl && navCtrl.getActive().component.name;
535+
536+
if (page == currentPage) {
537+
// Already at page, nothing to do.
538+
} else if (page == 'CoreLoginSitesPage') {
535539
// Just open the page as root.
536540
return navCtrl.setRoot(page, params);
541+
} else if (page == 'CoreLoginCredentialsPage' && currentPage == 'CoreLoginSitePage') {
542+
// Just open the new page to keep the navigation history.
543+
return navCtrl.push(page, params);
537544
} else {
538545
// Check if there is any site stored.
539546
return this.sitesProvider.hasSites().then((hasSites) => {

src/providers/urlschemes.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ export class CoreCustomURLSchemesProvider {
105105
await this.sitesProvider.checkRequiredMinimumVersion(result.config);
106106
}
107107

108-
return this.sitesProvider.newSite(data.siteUrl, data.token, data.privateToken, data.isSSOToken,
108+
return this.sitesProvider.newSite(data.siteUrl, data.token, data.privateToken, !!data.isSSOToken,
109109
this.loginHelper.getOAuthIdFromParams(data.ssoUrlParams));
110110
} else {
111111
// Token belongs to current site, no need to create it.

0 commit comments

Comments
 (0)