MOBILE-4134 core: Display error when opening APK in Android

Author: dpalou

scripts/langindex.json

@@ -1471,6 +1471,7 @@
   "core.cannotconnecttrouble": "local_moodlemobileapp",
   "core.cannotconnectverify": "local_moodlemobileapp",
   "core.cannotdownloadfiles": "local_moodlemobileapp",
+  "core.cannotinstallapk": "local_moodlemobileapp",
   "core.cannotlogoutpageblocks": "local_moodlemobileapp",
   "core.cannotopeninapp": "local_moodlemobileapp",
   "core.cannotopeninappdownload": "local_moodlemobileapp",

src/core/lang.json

@@ -18,6 +18,7 @@
     "cannotconnecttrouble": "We're having trouble connecting to your site.",
     "cannotconnectverify": "<strong>Please check the address is correct.</strong>",
     "cannotdownloadfiles": "File downloading is disabled. Please contact your site administrator.",
+    "cannotinstallapk": "For security reasons, it is not allowed to install unknown apps from the Moodle app. Please open the file using a browser.",
     "cannotlogoutpageblocks": "Please save or discard your changes before continuing.",
     "cannotopeninapp": "This file may not work as expected on this device. Would you like to open it anyway?",
     "cannotopeninappdownload": "This file may not work as expected on this device. Would you like to download it anyway?",

src/core/services/file-helper.ts

@@ -27,6 +27,7 @@ import { CoreConstants } from '@/core/constants';
 import { CoreError } from '@classes/errors/error';
 import { makeSingleton, Translate } from '@singletons';
 import { CoreNetworkError } from '@classes/errors/network-error';
+import { CoreMimetypeUtils } from './utils/mimetype';
 
 /**
  * Provider to provide some helper functions regarding files and packages.
@@ -303,18 +304,22 @@ export class CoreFileHelperProvider {
     }
 
     /**
-     * Whether the file has to be opened in browser (external repository).
-     * The file must have a mimetype attribute.
+     * Whether the file has to be opened in browser.
      *
      * @param file The file to check.
      * @return Whether the file should be opened in browser.
      */
     shouldOpenInBrowser(file: CoreWSFile): boolean {
-        if (!file || !('isexternalfile' in file) || !file.isexternalfile || !file.mimetype) {
+        if (!file.mimetype) {
             return false;
         }
 
         const mimetype = file.mimetype;
+        if (!('isexternalfile' in file) || !file.isexternalfile) {
+            return mimetype === 'application/vnd.android.package-archive' ||
+                CoreMimetypeUtils.getFileExtension(file.filename ?? '') === 'apk';
+        }
+
         if (mimetype.indexOf('application/vnd.google-apps.') != -1) {
             // Google Docs file, always open in browser.
             return true;

src/core/services/utils/utils.ts

@@ -34,6 +34,7 @@ import { CoreFileEntry } from '@services/file-helper';
 import { CoreConstants } from '@/core/constants';
 import { CoreWindow } from '@singletons/window';
 import { CoreColors } from '@singletons/colors';
+import { CoreError } from '@classes/errors/error';
 
 type TreeNode<T> = T & { children: TreeNode<T>[] };
 
@@ -958,6 +959,8 @@ export class CoreUtilsProvider {
             this.openInApp(path);
 
             return;
+        } else if (extension === 'apk' && CoreApp.isAndroid()) {
+            throw new CoreError(Translate.instant('core.cannotinstallapk'));
         }
 
         // Path needs to be decoded, the file won't be opened if the path has %20 instead of spaces and so.