Merge pull request #2451 from dpalou/MOBILE-3475

MOBILE-3475 core: Prevent errors when calling isVersionGreaterEqualThan

Author: jleyva

src/addon/block/myoverview/providers/block-handler.ts

@@ -37,7 +37,7 @@ export class AddonBlockMyOverviewHandler extends CoreBlockBaseHandler {
      * @return Whether or not the handler is enabled on a site level.
      */
     isEnabled(): boolean | Promise<boolean> {
-        return this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.6') ||
+        return (this.sitesProvider.getCurrentSite() && this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.6')) ||
             !this.coursesProvider.isMyCoursesDisabledInSite();
     }
 

src/addon/block/timeline/providers/block-handler.ts

@@ -41,7 +41,9 @@ export class AddonBlockTimelineHandler extends CoreBlockBaseHandler {
      */
     isEnabled(): boolean | Promise<boolean> {
         return this.timelineProvider.isAvailable().then((enabled) => {
-            return enabled && (this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.6') ||
+            const currentSite = this.sitesProvider.getCurrentSite();
+
+            return enabled && ((currentSite && currentSite.isVersionGreaterEqualThan('3.6')) ||
                 !this.coursesProvider.isMyCoursesDisabledInSite());
         });
     }

src/addon/calendar/providers/calendar.ts

@@ -393,7 +393,7 @@ export class AddonCalendarProvider {
         site = site || this.sitesProvider.getCurrentSite();
 
         // The WS to create/edit events requires a fix that was integrated in 3.7.1.
-        return site.isVersionGreaterEqualThan('3.7.1');
+        return site && site.isVersionGreaterEqualThan('3.7.1');
     }
 
     /**

src/addon/filter/multilang/providers/handler.ts

@@ -83,6 +83,6 @@ export class AddonFilterMultilangHandler extends CoreFilterDefaultHandler {
      */
     shouldBeApplied(options: CoreFilterFormatTextOptions, site?: CoreSite): boolean {
         // The filter should be applied if site is older than 3.7 or the WS didn't filter the text.
-        return options.wsNotFiltered || !site.isVersionGreaterEqualThan('3.7');
+        return options.wsNotFiltered || (site && !site.isVersionGreaterEqualThan('3.7'));
     }
 }

src/addon/mod/assign/components/index/index.ts

@@ -207,9 +207,10 @@ export class AddonModAssignIndexComponent extends CoreCourseModuleMainActivityCo
 
                     // Check if groupmode is enabled to avoid showing wrong numbers.
                     return this.groupsProvider.getActivityGroupInfo(this.assign.cmid, false).then((groupInfo) => {
+                        const currentSite = this.sitesProvider.getCurrentSite();
                         this.groupInfo = groupInfo;
                         this.showNumbers = groupInfo.groups.length == 0 ||
-                            this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.5');
+                            (currentSite && currentSite.isVersionGreaterEqualThan('3.5'));
 
                         return this.setGroup(this.groupsProvider.validateGroupId(this.group, groupInfo));
                     });
@@ -258,8 +259,10 @@ export class AddonModAssignIndexComponent extends CoreCourseModuleMainActivityCo
                 }
             }
 
+            const currentSite = this.sitesProvider.getCurrentSite();
+
             this.needsGradingAvalaible = response.gradingsummary && response.gradingsummary.submissionsneedgradingcount > 0 &&
-                    this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.2');
+                    currentSite && currentSite.isVersionGreaterEqualThan('3.2');
         });
     }
 

src/addon/mod/assign/submission/onlinetext/providers/handler.ts

@@ -225,7 +225,7 @@ export class AddonModAssignSubmissionOnlineTextHandler implements AddonModAssign
         // Bug was fixed in 3.1.1 minor release and in 3.2.
         const currentSite = this.sitesProvider.getCurrentSite();
 
-        return currentSite.isVersionGreaterEqualThan('3.1.1') || currentSite.checkIfAppUsesLocalMobile();
+        return currentSite && (currentSite.isVersionGreaterEqualThan('3.1.1') || currentSite.checkIfAppUsesLocalMobile());
     }
 
     /**

src/addon/mod/forum/providers/forum.ts

@@ -291,7 +291,8 @@ export class AddonModForumProvider {
      * @return True if fixed, false otherwise.
      */
     isAllParticipantsFixed(): boolean {
-        return this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan(['3.1.5', '3.2.2']);
+        return this.sitesProvider.getCurrentSite() &&
+                this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan(['3.1.5', '3.2.2']);
     }
 
     /**
@@ -543,7 +544,7 @@ export class AddonModForumProvider {
     isDiscussionListSortingAvailable(site?: CoreSite): boolean {
         site = site || this.sitesProvider.getCurrentSite();
 
-        return site.isVersionGreaterEqualThan('3.7');
+        return site && site.isVersionGreaterEqualThan('3.7');
     }
 
     /**

src/addon/mod/forum/providers/prefetch-handler.ts

@@ -87,7 +87,8 @@ export class AddonModForumPrefetchHandler extends CoreCourseActivityPrefetchHand
      */
     protected getPostsFiles(posts: any[]): any[] {
         let files = [];
-        const getInlineFiles = this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.2');
+        const getInlineFiles = this.sitesProvider.getCurrentSite() &&
+                this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.2');
 
         posts.forEach((post) => {
             if (post.attachments && post.attachments.length) {

src/addon/mod/glossary/providers/prefetch-handler.ts

@@ -86,7 +86,8 @@ export class AddonModGlossaryPrefetchHandler extends CoreCourseActivityPrefetchH
      */
     protected getFilesFromGlossaryAndEntries(module: any, glossary: any, entries: any[]): any[] {
         let files = this.getIntroFilesFromInstance(module, glossary);
-        const getInlineFiles = this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.2');
+        const getInlineFiles = this.sitesProvider.getCurrentSite() &&
+                this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.2');
 
         // Get entries files.
         entries.forEach((entry) => {

src/addon/mod/quiz/providers/prefetch-handler.ts

@@ -110,8 +110,9 @@ export class AddonModQuizPrefetchHandler extends CoreCourseActivityPrefetchHandl
      */
     protected getAttemptsFeedbackFiles(quiz: any, attempts: any[]): Promise<any[]> {
         // We have quiz data, now we'll get specific data for each attempt.
-        const promises = [],
-            getInlineFiles = this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.2');
+        const promises = [];
+        const getInlineFiles = this.sitesProvider.getCurrentSite() &&
+                this.sitesProvider.getCurrentSite().isVersionGreaterEqualThan('3.2');
         let files = [];
 
         attempts.forEach((attempt) => {