MOBILE-4983 chore: Improve admin detection and detect manager role

Author: crazyserver

src/core/classes/sites/authenticated-site.ts

@@ -232,12 +232,25 @@ export class CoreAuthenticatedSite extends CoreUnauthenticatedSite {
 
     /**
      * Check if current user is Admin.
-     * Works properly since v3.8. See more in: {@link https://moodle.atlassian.net/browse/MDL-65550}
+     * Works properly since Moodle 3.8. See more in: {@link https://moodle.atlassian.net/browse/MDL-65550}
      *
      * @returns Whether the user is Admin.
      */
     isAdmin(): boolean {
-        return this.getInfo()?.userissiteadmin ?? false;
+        const info = this.getInfo();
+
+        return (info?.userissiteadmin || info?.usercanchangeconfig) ?? false;
+    }
+
+    /**
+     * Check if current user is Manager.
+     * Works properly since Moodle 5.2. See more in: {@link https://moodle.atlassian.net/browse/MDL-87034}
+     *
+     * @returns Whether the user is Manager. Will return false if cannot be determined.
+     * @since 5.2
+     */
+    isManager(): boolean {
+        return this.getInfo()?.usercanviewconfig ?? false;
     }
 
     /**

src/core/features/settings/pages/dev/dev.html

@@ -97,6 +97,34 @@ <h1>{{ 'core.settings.developeroptions' | translate }}</h1>
 
         @if (siteId) {
 
+            <ion-item class="ion-text-wrap">
+                <ion-label>
+                    <p class="item-heading">Is admin</p>
+                    <p>
+                        @if (isAdmin) {
+                            {{ 'core.yes' | translate }}
+                        } @else {
+                            {{ 'core.no' | translate }}
+                        }
+                    </p>
+                </ion-label>
+            </ion-item>
+
+            @if (isManager !== undefined) {
+                <ion-item class="ion-text-wrap">
+                    <ion-label>
+                        <p class="item-heading">Is manager</p>
+                        <p>
+                            @if (isManager) {
+                                {{ 'core.yes' | translate }}
+                            } @else {
+                                {{ 'core.no' | translate }}
+                            }
+                        </p>
+                    </ion-label>
+                </ion-item>
+            }
+
             <ion-item class="ion-text-wrap">
                 <ion-label>
                     <p class="item-heading">WebService token</p>
@@ -151,16 +179,17 @@ <h1>{{ 'core.settings.developeroptions' | translate }}</h1>
                     <h2>Disabled features</h2>
                 </ion-label>
             </ion-item-divider>
-            @if (disabledFeatures.length === 0) {
+            @for (feature of disabledFeatures; track feature) {
+                <ion-item class="ion-text-wrap">
+                    <ion-label>
+                        <p class="item-heading">{{ feature }}</p>
+                    </ion-label>
+                </ion-item>
+            } @empty {
                 <ion-item>
                     <ion-label>There are no features disabled.</ion-label>
                 </ion-item>
             }
-            <ion-item class="ion-text-wrap" *ngFor="let feature of disabledFeatures">
-                <ion-label>
-                    <p class="item-heading">{{ feature }}</p>
-                </ion-label>
-            </ion-item>
 
             <ion-item-divider>
                 <ion-label>
@@ -191,17 +220,19 @@ <h2>WebService overrides</h2>
                     <h2>Site plugins</h2>
                 </ion-label>
             </ion-item-divider>
-            @if (sitePlugins.length === 0) {
+
+            @for (plugin of sitePlugins; track plugin) {
+                <ion-item class="ion-text-wrap">
+                    <ion-label>
+                        <p class="item-heading">{{ plugin.addon }} ({{plugin.component}})</p>
+                        <p>{{plugin.version}}</p>
+                    </ion-label>
+                </ion-item>
+            } @empty {
                 <ion-item>
                     <ion-label>There are no site plugins installed</ion-label>
                 </ion-item>
             }
-            <ion-item class="ion-text-wrap" *ngFor="let plugin of sitePlugins">
-                <ion-label>
-                    <p class="item-heading">{{ plugin.addon }} ({{plugin.component}})</p>
-                    <p>{{plugin.version}}</p>
-                </ion-label>
-            </ion-item>
 
         }
     </ion-list>

src/core/features/settings/pages/dev/dev.ts

@@ -34,6 +34,7 @@ import { CoreText } from '@singletons/text';
 import { CoreAlerts } from '@services/overlays/alerts';
 import { CoreLoadings } from '@services/overlays/loadings';
 import { CoreSharedModule } from '@/core/shared.module';
+import { CoreSitePlugins } from '@features/siteplugins/services/siteplugins';
 
 /**
  * Page that displays the developer options.
@@ -61,6 +62,8 @@ export default class CoreSettingsDevPage implements OnInit {
     stagingSitesCount = 0;
     enableStagingSites?: boolean;
     previousEnableStagingSites?: boolean;
+    isAdmin = false;
+    isManager?: boolean;
 
     disabledFeatures: string[] = [];
 
@@ -115,23 +118,28 @@ export default class CoreSettingsDevPage implements OnInit {
         this.autoLoginTimeBetweenRequests = await currentSite.getAutoLoginMinTimeBetweenRequests();
         this.lastAutoLoginTime = currentSite.getLastAutoLoginTime();
 
+        this.isAdmin = currentSite.isAdmin();
+        // Check isManager only if LMS version is >= 5.2 because the function works properly since that version.
+        if (currentSite.isVersionGreaterEqualThan('5.2')) {
+            this.isManager = currentSite.isManager();
+        }
+
         document.head.querySelectorAll('style').forEach((style) => {
             if (this.siteId && style.id.endsWith(this.siteId)) {
                 if (style.innerHTML.length > 0) {
                     this.remoteStylesCount++;
                 }
-                this.remoteStyles = this.remoteStyles || style.getAttribute('media') != 'disabled';
+                this.remoteStyles = this.remoteStyles || style.getAttribute('media') !== 'disabled';
             }
 
             if (style.id.startsWith('siteplugin-')) {
                 if (style.innerHTML.length > 0) {
                     this.pluginStylesCount++;
                 }
-                this.pluginStyles = this.pluginStyles || style.getAttribute('media') != 'disabled';
+                this.pluginStyles = this.pluginStyles || style.getAttribute('media') !== 'disabled';
             }
         });
 
-        const { CoreSitePlugins } = await import('@features/siteplugins/services/siteplugins');
         this.sitePlugins = CoreSitePlugins.getCurrentSitePluginList().map((plugin) => ({
             addon: plugin.addon,
             component: plugin.component,