MOBILE-2178 database: Fix isEmpty and pagination in list

Author: dpalou

www/addons/mod/data/controllers/index.js

@@ -190,9 +190,9 @@ angular.module('mm.addons.mod_data')
                     $scope.search.page);
             }
         }).then(function(entries) {
-            $scope.numEntries = entries && entries.totalcount;
-            $scope.isEmpty = $scope.numEntries <= 0 && $scope.offlineActions.length <= 0;
-            $scope.hasNextPage = (($scope.search.page + 1) * mmaModDataPerPage) < $scope.numEntries;
+            var numEntries = (entries && entries.entries && entries.entries.length) || 0;
+            $scope.isEmpty = !numEntries && Object.keys($scope.offlineActions).length <= 0;
+            $scope.hasNextPage = numEntries >= mmaModDataPerPage && (($scope.search.page + 1) * mmaModDataPerPage) < entries.totalcount;
             $scope.entriesRendered = "";
 
             if (!$scope.isEmpty) {

www/addons/mod/data/templates/index.html

@@ -49,7 +49,6 @@
             </div>
 
             <div class="item" ng-if="search.searching && !isEmpty">
-                <h2>{{ 'mma.mod_data.numrecords' | translate: {$a: numEntries } }}</h2>
                 <a ng-click="searchReset()">{{ 'mma.mod_data.resetsettings' | translate}}</a>
             </div>
 

www/core/scss/styles.scss

@@ -1683,3 +1683,7 @@ h2.invert {
 ::-webkit-calendar-picker-indicator, ::-webkit-inner-spin-button, ::-webkit-clear-button {
   display: none;
 }
+
+*[ng-click] {
+  cursor: pointer;
+}