Skip to content

Commit dac5834

Browse files
MOBILE-4077 ReportBuilder: Show empty box when there isn't report detail to display
1 parent f84a0c6 commit dac5834

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

src/core/features/reportbuilder/components/report-detail/report-detail.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22

33
<core-loading [hideUntil]="state.loaded">
44

5-
<ng-container *ngIf="state.report?.data?.rows && state.report?.data?.headers && state.report?.details; else empty">
5+
<ion-refresher slot="fixed" [disabled]="!state.loaded" (ionRefresh)="refreshReport($event.target)">
6+
<ion-refresher-content pullingText="{{ 'core.pulltorefresh' | translate }}"></ion-refresher-content>
7+
</ion-refresher>
68

7-
<ion-refresher slot="fixed" [disabled]="!state.loaded" (ionRefresh)="refreshReport($event.target)">
8-
<ion-refresher-content pullingText="{{ 'core.pulltorefresh' | translate }}"></ion-refresher-content>
9-
</ion-refresher>
9+
<ng-container *ngIf="state.report?.data?.rows?.length && state.report?.data?.headers && state.report?.details; else empty">
1010

1111
<ng-container *ngIf="isCardLayout">
1212
<ion-card *ngFor="let row of state.report.data.rows; let rowIndex = index">
@@ -46,15 +46,15 @@
4646
</ng-container>
4747

4848
<ng-template #empty>
49-
<core-empty-box *ngIf="!state.report?.data?.rows || !state.report?.data?.headers || !state.report?.details" icon="fa-list-alt"
50-
[message]="'core.course.nocontentavailable' | translate"></core-empty-box>
49+
<core-empty-box icon="fa-list-alt">
50+
<p> {{ 'core.course.nocontentavailable' | translate }} </p>
51+
</core-empty-box>
5152
</ng-template>
5253

53-
<core-infinite-loading *ngIf="!isBlock && state.report?.data?.rows && state.report?.data?.headers && state.report?.details"
54+
<core-infinite-loading *ngIf="!isBlock && state.report?.data?.rows?.length && state.report?.data?.headers && state.report?.details"
5455
[enabled]="state.canLoadMoreRows" (action)="fetchMoreInfo($event)" [error]="state.errorLoadingRows">
5556
</core-infinite-loading>
5657

57-
5858
</core-loading>
5959

6060
</ng-container>

src/core/features/reportbuilder/components/report-detail/report-detail.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,12 @@
4141
}
4242

4343
}
44+
45+
core-empty-box {
46+
color: var(--gray-500);
47+
p {
48+
color: var(--gray-900);
49+
}
50+
}
51+
4452
}

0 commit comments

Comments
 (0)