Merge pull request #2516 from dpalou/MOBILE-3501

MOBILE-3501 npm: Make keytar lib optional

Author: jleyva

.travis.yml

@@ -32,9 +32,6 @@ cache:
     - $HOME/.gradle/wrapper/
     - $HOME/.android/build-cache
 
-before_install:
-  - if [ "$TRAVIS_OS_NAME" == 'linux' ] ; then sudo apt-get install -y libsecret-1-dev > /dev/null ; fi
-
 before_script:
   - if [ "$TRAVIS_OS_NAME" != 'windows' ] ; then  npm install npm@latest -g ; fi
   - gulp
@@ -67,7 +64,6 @@ jobs:
     - node --version
     - npm --version
     - nvm --version
-    - sudo apt-get install -y libsecret-1-dev > /dev/null
     - npm ci
     - npm install -g gulp
     script: scripts/aot.sh

gulp/jira.js

@@ -14,7 +14,6 @@
 
 const exec = require('child_process').exec;
 const https = require('https');
-const keytar = require('keytar');
 const inquirer = require('inquirer');
 const fs = require('fs');
 const request = require('request'); // This lib is deprecated, but it was the only way I found to make upload files work.
@@ -246,6 +245,8 @@ class Jira {
         this.uri = parsed.path;
 
         // Get the password.
+        const keytar = require('keytar');
+
         this.password = await keytar.getPassword('mdk-jira-password', this.username); // Use same service name as mdk.
 
         if (!this.password) {