Skip to content

Commit fc98bf5

Browse files
MOBILE-4077 ReportBuilder: Sort reports list and update lang strings
1 parent 7b37a90 commit fc98bf5

File tree

5 files changed

+8
-8
lines changed

5 files changed

+8
-8
lines changed

scripts/langindex.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1653,9 +1653,9 @@
16531653
"core.currentdevice": "local_moodlemobileapp",
16541654
"core.custom": "form",
16551655
"core.reportbuilder.modifiedby": "tool_reportbuilder",
1656-
"core.reportbuilder.reportstab": "tool_reportbuilder",
1657-
"core.reportbuilder.reportsource": "tool_reportbuilder",
1658-
"core.reportbuilder.timecreated": "tool_reportbuilder",
1656+
"core.reportbuilder.reports": "moodle",
1657+
"core.reportbuilder.reportsource": "moodle",
1658+
"core.reportbuilder.timecreated": "moodle",
16591659
"core.reportbuilder.showcolumns": "local_moodlemobileapp",
16601660
"core.reportbuilder.hidecolumns": "local_moodlemobileapp",
16611661
"core.datastoredoffline": "local_moodlemobileapp",

src/core/features/reportbuilder/classes/reports-source.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ export class CoreReportBuilderReportsSource extends CoreRoutedItemsManagerSource
4141
*/
4242
protected setItems(reports: CoreReportBuilderReport[], hasMoreItems: boolean): void {
4343
const sortedReports = reports.slice(0);
44-
reports.sort((a, b) => a.timecreated < b.timecreated ? 1 : -1);
44+
sortedReports.sort((a, b) => a.timemodified < b.timemodified ? 1 : -1);
4545
super.setItems(sortedReports, hasMoreItems);
4646
}
4747

src/core/features/reportbuilder/lang.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"modifiedby": "Modified by",
3-
"reportstab": "Reports",
3+
"reports": "Reports",
44
"reportsource": "Report source",
55
"timecreated": "Time created",
66
"showcolumns": "Show columns",

src/core/features/reportbuilder/pages/list/list.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<ion-back-button [text]="'core.back' | translate"></ion-back-button>
55
</ion-buttons>
66
<ion-title>
7-
<h1>{{ 'core.reportbuilder.reportstab' | translate }}</h1>
7+
<h1>{{ 'core.reportbuilder.reports' | translate }}</h1>
88
</ion-title>
99
</ion-toolbar>
1010
</ion-header>

src/core/features/reportbuilder/services/handlers/reportbuilder.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,11 @@ export class CoreReportBuilderHandlerService implements CoreUserProfileHandler {
4545
return {
4646
class: 'core-report-builder',
4747
icon: 'fa-list-alt',
48-
title: 'core.reportbuilder.reportstab',
48+
title: 'core.reportbuilder.reports',
4949
action: async (event): Promise<void> => {
5050
event.preventDefault();
5151
event.stopPropagation();
52-
await CoreNavigator.navigate(`/${CoreReportBuilderHandlerService.PAGE_NAME}`);
52+
await CoreNavigator.navigateToSitePath(CoreReportBuilderHandlerService.PAGE_NAME);
5353
},
5454
};
5555
}

0 commit comments

Comments
 (0)