MOBILE-4840 keyboard: Use getters for accessing read-only signals

Author: albertgasset

src/core/features/comments/pages/viewer/viewer.ts

@@ -129,10 +129,10 @@ export default class CoreCommentsViewerPage implements OnInit, OnDestroy, AfterV
         });
 
         effect(() => {
-            const shown = CoreKeyboard.getKeyboardShownSignal();
+            const shown = CoreKeyboard.keyboardShownSignal();
 
             /// Force when opening.
-            this.scrollToBottom(shown());
+            this.scrollToBottom(shown);
         });
     }
 

src/core/features/editor/components/rich-text-editor/rich-text-editor.ts

@@ -111,7 +111,7 @@ export class CoreEditorRichTextEditorComponent implements AfterViewInit, OnDestr
 
         effect(() => {
             // Signal will be triggered when the keyboard is shown or hidden.
-            CoreKeyboard.getKeyboardShownSignal();
+            CoreKeyboard.keyboardShownSignal();
 
             // Opening or closing the keyboard also calls the resize function, but sometimes the resize is called too soon.
             // Check the height again, now the window height should have been updated.

src/core/features/mainmenu/pages/menu/menu.ts

@@ -123,7 +123,7 @@ export default class CoreMainMenuPage implements OnInit, OnDestroy {
 
         if (CorePlatform.isIOS()) {
             effect(() => {
-                const shown = CoreKeyboard.getKeyboardShownSignal();
+                const shown = CoreKeyboard.keyboardShownSignal();
                 // In iOS, the resize event is triggered before the keyboard is opened/closed and not triggered again once done.
                 // Init handlers again once keyboard is closed since the resize event doesn't have the updated height.
                 if (!shown) {

src/core/singletons/keyboard.ts

@@ -58,7 +58,7 @@ export class CoreKeyboard {
      *
      * @returns Signal indicating whether the keyboard is shown.
      */
-    static getKeyboardShownSignal(): Signal<boolean> {
+    static get keyboardShownSignal(): Signal<boolean> {
         return CoreKeyboard.IS_KEYBOARD_SHOWN.asReadonly();
     }
 
@@ -67,7 +67,7 @@ export class CoreKeyboard {
      *
      * @returns Signal indicating the keyboard height.
      */
-    static getKeyboardHeightSignal(): Signal<number> {
+    static get keyboardHeightSignal(): Signal<number> {
         return CoreKeyboard.KEYBOARD_HEIGHT.asReadonly();
     }