Non-admins cannot access the workflow management page /blocks/workflow/manage.php

[abias]

Steps to reproduce:

• Login as admin
• Go to the roles management page and edit the manager role
• Add all block/workflow:* capabilities to the manager role, but make especially sure that you add the block/workflow:editdefinitions capability
• Login as manager

Expected result:

• If you go to Site administration -> Plugins, you will see the "Blocks" section and a "Workflow" link within it
• If you go directly to /blocks/workflow/manage.php, you will be able to edit the workflows of this plugin

Actual result:

• If you go to Site administration -> Plugins, you will not a "Workflow" link
• If you go directly to /blocks/workflow/manage.php, you will get a "Access denied" exception

[timhunt]

Since the bits higher up the nav tree are created by Moodle core, and only exist for site admins, then we cannot really add the settings there.

The work-around I used in another plugin's settings.php file was

    // For people with full admin access, we add these pages to localplugins.
    // For people who don't see those branches (e.g. ACQ admins) we add to the root level.
    if ($ADMIN->locate('localplugins')) {
        $parent = 'localplugins';
    } else {
        $parent = 'root';
    }

then add all the things we wanted to add under $parent, rather than at a hard-coded location.

We should do a similar thing for workflow (block and report). Do you want to code a pull request?