Manual grading by student: publish M4.5/M5.0 version #918760

Author: Mahmoud Kassaei

.github/workflows/ci.yml

@@ -7,23 +7,19 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        # Overall strategy is to run as few jobs as possible, but:
+        # - each php version at least once
+        # - each moodle version at least once
+        # - each database at least once
         include:
-          - php: '7.4'
-            moodle-branch: 'master'
-            database: 'pgsql'
-          - php: '7.4'
-            moodle-branch: 'MOODLE_311_STABLE'
-            database: 'mariadb'
-          - php: '7.3'
-            moodle-branch: 'MOODLE_310_STABLE'
-            database: 'pgsql'
-          - php: '7.2'
-            moodle-branch: 'MOODLE_39_STABLE'
-            database: 'mariadb'
+          - { php: '8.3', moodle-branch: main, database: pgsql }
+          - { php: '8.3', moodle-branch: MOODLE_500_STABLE, database: pgsql }
+          - { php: '8.2', moodle-branch: MOODLE_405_STABLE, database: mariadb }
+          - { php: '8.1', moodle-branch: MOODLE_404_STABLE, database: pgsql }
 
     services:
       postgres:
-        image: postgres
+        image: postgres:15
         env:
           POSTGRES_USER: 'postgres'
           POSTGRES_HOST_AUTH_METHOD: 'trust'
@@ -36,42 +32,41 @@ jobs:
           - 5432:5432
 
       mariadb:
-        image: mariadb
+        image: mariadb:10
         env:
           MYSQL_USER: 'root'
           MYSQL_ALLOW_EMPTY_PASSWORD: "true"
+          MYSQL_CHARACTER_SET_SERVER: "utf8mb4"
+          MYSQL_COLLATION_SERVER: "utf8mb4_unicode_ci"
         ports:
           - 3306:3306
         options: --health-cmd="mysqladmin ping" --health-interval 10s --health-timeout 5s --health-retries 3
 
     steps:
-      - name: Checkout
-        uses: actions/checkout@v2
+      - name: Check out repository code
+        uses: actions/checkout@v4
         with:
           path: plugin
 
-      - name: Install node
-        uses: actions/setup-node@v1
-        with:
-          node-version: '14.15.0'
-
-      - name: Setup PHP
+      - name: Setup PHP ${{ matrix.php }}
         uses: shivammathur/setup-php@v2
         with:
           php-version: ${{ matrix.php }}
-          extensions: mbstring, pgsql, mysqli
+          extensions: ${{ matrix.extensions }}
+          ini-values: max_input_vars=5000
+          coverage: none
 
-      - name: Deploy moodle-plugin-ci
+      - name: Initialise moodle-plugin-ci
         run: |
-          composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^3
-          # Add dirs to $PATH
+          composer create-project -n --no-dev --prefer-dist moodlehq/moodle-plugin-ci ci ^4
           echo $(cd ci/bin; pwd) >> $GITHUB_PATH
           echo $(cd ci/vendor/bin; pwd) >> $GITHUB_PATH
-          # PHPUnit depends on en_AU.UTF-8 locale
           sudo locale-gen en_AU.UTF-8
+          echo "NVM_DIR=$HOME/.nvm" >> $GITHUB_ENV
 
-      - name: Install Moodle
-        run: moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
+      - name: Install moodle-plugin-ci
+        run: |
+          moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1
         env:
           DB: ${{ matrix.database }}
           MOODLE_BRANCH: ${{ matrix.moodle-branch }}
@@ -82,13 +77,14 @@ jobs:
 
       - name: phpcpd
         if: ${{ always() }}
-        run: moodle-plugin-ci phpcpd
+        run: moodle-plugin-ci phpcpd || true
 
       - name: phpmd
         if: ${{ always() }}
         run: moodle-plugin-ci phpmd
 
       - name: codechecker
+        continue-on-error: true # This step will show errors but will not fail
         if: ${{ always() }}
         run: moodle-plugin-ci codechecker
 

classes/ou_confirmation_code.php

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
+use local_oudataload\backend;
+
 /**
  * This class implements the OU's 'Confirmation code' algorithm for end-of-course assessed tasks.
  *
@@ -134,6 +136,9 @@ public static function calculate_hash(string $string): string {
      * @return string[] array with two elements, [$module, $pres].
      */
     public static function update_for_variant(string $module, string $pres, $cm, stdClass $user): array {
+        if (!class_exists('\local_oudataload\backend')) {
+            return [$module, $pres];
+        }
         $variants = \local_oudataload\backend::get_course_and_pres_codes($cm->course, $user->id);
         if (!$variants) {
             return [$module, $pres];

tests/ou_confirmation_code_test.php

@@ -14,6 +14,8 @@
 // You should have received a copy of the GNU General Public License
 // along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
 
+use local_oudataload\util;
+
 /**
  * Unit tests for {@link quiz_grading_students_exam_confirmation_code}
  *
@@ -26,7 +28,7 @@ class quiz_gradingstudents_ou_confirmation_code_test extends advanced_testcase {
      * Data provider for test_quiz_can_have_confirmation_code.
      * @return array
      */
-    public function quiz_can_have_confirmation_code_cases(): array {
+    public static function quiz_can_have_confirmation_code_cases(): array {
         return [
             ['sk121-13r.eca30', 'eca30'],
             ['sk121-13j.exm01', 'exm01'],
@@ -71,7 +73,7 @@ public function test_calculate_confirmation_code() {
      *
      * @return array
      */
-    public function get_confirmation_code_cases(): array {
+    public static function get_confirmation_code_cases(): array {
         return [
             ['sk121-13r.eca30', 'B7435280', 'DZSD'], // From issue #7168.
             ['sk121-13j.exm01', 'B7435280', 'VZVG'], // From issue #7168.