Edit dates/groups/idnumber: Update to work with Moodle 4.0 #547712

Author: Mahmoud Kassaei

.github/workflows/ci.yml

@@ -14,12 +14,6 @@ jobs:
           - php: '7.4'
             moodle-branch: 'MOODLE_311_STABLE'
             database: 'mariadb'
-          - php: '7.3'
-            moodle-branch: 'MOODLE_310_STABLE'
-            database: 'pgsql'
-          - php: '7.2'
-            moodle-branch: 'MOODLE_39_STABLE'
-            database: 'mariadb'
 
     services:
       postgres:
@@ -50,11 +44,6 @@ jobs:
         with:
           path: plugin
 
-      - name: Install node
-        uses: actions/setup-node@v1
-        with:
-          node-version: '14.15.0'
-
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:

changes.md

@@ -1,5 +1,12 @@
 # Change log for the Edit ID numbers report
 
+## Changes in 2.6
+
+* This version works with Moodle 4.0.
+* Updated to use Moodle 3.11 navigation
+* Switch from Travis to Github actions.
+* Update Travis config.
+* Update to Travis-CI config.
 
 ## Changes in 2.5
 

index.php

@@ -44,7 +44,6 @@
     $urlparams['activitytype'] = $activitytype;
 }
 $pageurl = new moodle_url('/report/editidnumber/index.php', $urlparams);
-report_helper::save_selected_report($id, $pageurl);
 $PAGE->set_url($pageurl);
 $PAGE->set_pagelayout('admin');
 

tests/behat/basic.feature

@@ -37,8 +37,7 @@ Feature: Edit course plugin ID numbers
 
   @javascript @_switch_iframe
   Scenario: Test edit ID number report can be used to change plugin instance ID numbers
-    When I log in as "admin"
-    And I am on "Course 1" course homepage
+    When I am on the "Course 1" "course" page logged in as "admin"
     And I navigate to "Reports > ID numbers" in current page administration
     And I follow "ID numbers"
     Then I should see "Course 1"
@@ -47,14 +46,14 @@ Feature: Edit course plugin ID numbers
     And I should see "Test quiz name 1"
     And I should see "Test quiz name 2"
     And I should see "Test quiz name 3"
-    And I set the field with xpath "//fieldset[@id='id_section2header']/div[@class='fcontainer clearfix']/div[2]/div[contains(@class,'felement')]/input[@type='text']" to "1"
-    And I set the field with xpath "//fieldset[@id='id_section3header']/div[@class='fcontainer clearfix']/div[2]/div[contains(@class,'felement')]/input[@type='text']" to "2"
+    And I set the field with xpath "//fieldset[@id='id_section2header']//div[contains(@class,'felement')]/input[@type='text']" to "1"
+    And I set the field with xpath "//fieldset[@id='id_section3header']//div[contains(@class,'felement')]/input[@type='text']" to "2"
     And I press "Save changes"
     Then I should see "Course 1"
     And I should see "Activity view filter "
     And I follow "Expand all"
     And I should see "Test quiz name 1"
     And I should see "Test quiz name 2"
     And I should see "Test quiz name 3"
-    And the "value" attribute of "//fieldset[@id='id_section2header']/div[@class='fcontainer clearfix']/div[2]/div[contains(@class,'felement')]/input[@type='text']" "xpath_element" should contain "1"
-    And the "value" attribute of "//fieldset[@id='id_section3header']/div[@class='fcontainer clearfix']/div[2]/div[contains(@class,'felement')]/input[@type='text']" "xpath_element" should contain "2"
+    And the "value" attribute of "//fieldset[@id='id_section2header']//div[contains(@class,'felement')]/input[@type='text']" "xpath_element" should contain "1"
+    And the "value" attribute of "//fieldset[@id='id_section3header']//div[contains(@class,'felement')]/input[@type='text']" "xpath_element" should contain "2"

tests/behat/course_report_editidnumber.feature

@@ -1,5 +1,5 @@
 @report @report_editidnumber @ou @ou_vle
-Feature: Edit idnumber report navigation
+Feature: In a course administration page, navigate through report page, test for course ID numbers page
   In order to navigate through report page
   As an admin
   Go to course administration -> Reports -> ID numbers
@@ -17,7 +17,7 @@ Feature: Edit idnumber report navigation
       | student1 | C1 | student |
 
   @javascript
-  Scenario: Selector should be available in the Edit idnumber report
+  Scenario: Selector should be available in the Activities and resources page
     Given I log in as "admin"
     And I am on "Course 1" course homepage
     When I navigate to "Reports > ID numbers" in current page administration

version.php

@@ -24,10 +24,10 @@
 
 defined('MOODLE_INTERNAL') || die;
 
-$plugin->version   = 2018112100;
-$plugin->requires  = 2017111300;
+$plugin->version   = 2022061700;
+$plugin->requires  = 2020061500;
 $plugin->component = 'report_editidnumber';
 $plugin->maturity  = MATURITY_STABLE;
-$plugin->release   = '2.5 for Moodle 3.4+';
+$plugin->release   = '2.6 for Moodle 3.11+';
 
 $plugin->outestssufficient = true;