Error when clicking on a Latest report link

[pkgh]

My system:

Moodle 3.9.8 (Build: 20210712)

Embed questions
filter_embedquestion
2.1 for Moodle 3.9+
2021080600

Embed question
atto_embedquestion
1.7 for Moodle 3.9+
2020080600

Embedded questions progress
report_embedquestion
1.5 for Moodle 3.9+
2021080600

After embedding a question in a course label, when accessing the Embedded question progress report and clicking on an attempt link in the "Latest attempt" colum, I get such an error:

Notice: Trying to get property 'pageurl' of non-object in /ocfs2/www/owko/report/embedquestion/classes/utils.php on line 219
Notice: Trying to get property 'embedid' of non-object in /ocfs2/www/owko/report/embedquestion/classes/utils.php on line 220
Exception - Argument 1 passed to filter_embedquestion\embed_id::create_from_string() must be of the type string, null given, called in [dirroot]/report/embedquestion/classes/utils.php on line 220

Debug info:
Error code: generalexceptionmessage
Stack trace:

line 66 of /filter/embedquestion/classes/embed_id.php: TypeError thrown
line 220 of /report/embedquestion/classes/utils.php: call to filter_embedquestion\embed_id::create_from_string()
line 54 of /report/embedquestion/classes/utils.php: call to report_embedquestion\utils::get_activity_link()
line 207 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\utils::get_embed_location_summary()
line 183 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\local\report\progress_report->display_attempt_summary()
line 81 of /report/embedquestion/activity.php: call to report_embedquestion\local\report\progress_report->display()

Also, all CSS (Boost theme) breaks.

Attached screenshot:

[timhunt]

My guess is that this comes from old, bad, data in the report_embedquestion_attempt DB table.

Can you check the contents of that table, and see if there are any rows where pageurl or embedid is blank. (If so, you probably need to delete those rows.)

[pkgh]

Not really , my table is filled in - see attached
One thing I did when testing was post-edit the question ID; i had then to re-embed the question, as the filter was throwing an error.Still, some of the entries from that table should produce valid reports, but they do not.

[pkgh]

PS. It could that specifically labels produce such errors. I have just tested descriptions in Assignments as well as Pages, and these attempts can be reviewed successfully from the embedded questions progress report page.
Not sure how soon I will try other context / activity / resource types, but right now it seems that labels misbehave.

[timhunt]

Ah! then perhaps it is a bug. (I don't think I have seen an embedded question in a label at the OU.) I'm sorry I don't have time to look at this now (I am about to go on Holiday). I will try to investigate in future.

[pkgh]

No problem. We're only beginning to explore this use of questions anyway . I have managed to disable these links to latest attempts just in case for now - using such CSS: body#page-report-embedquestion-index td[id^="report_embedquestion_latest_attempt"] a[title="Attempt summary"] {pointer-events: none;} Have a grand holiday :)

[pkgh]

Hello, Tim, I was wondering if there;s is any chance to look into this bug soon.
It is still affecting Moodle 3.11 labels.
Kind regards.

[timhunt]

It's odd. I can't reproduce this just by embedded a question in a label, then checking out the report. That is on a 3.11 site.

Can you give me the error message you are getting with the latest version of report_embedquestion. The line numbers in the errors above no longer correspond.

[pkgh]

Tested using:
Moodle 3.11.8 (Build: 20220711) + Boost theme

Embed questions
filter_embedquestion
2.2 for Moodle 3.9+
2022032900

Embed question
atto_embedquestion
1.8 for Moodle 3.9+
2022032900

Embedded questions progress
report_embedquestion
1.7 for Moodle 3.11+
2022032900

When clicking on latest attempt link for question embedded in label - question type: Matching

Notice: Trying to get property 'pageurl' of non-object in /ocfs2/www/test39/report/embedquestion/classes/utils.php on line 206
Notice: Trying to get property 'embedid' of non-object in /ocfs2/www/test39/report/embedquestion/classes/utils.php on line 207

Exception - Argument 1 passed to filter_embedquestion\embed_id::create_from_string() must be of the type string, null given, called in [dirroot]/report/embedquestion/classes/utils.php on line 207

More information about this error
Debug info:
Error code: generalexceptionmessage
Stack trace:

line 57 of /filter/embedquestion/classes/embed_id.php: TypeError thrown
line 207 of /report/embedquestion/classes/utils.php: call to filter_embedquestion\embed_id::create_from_string()
line 45 of /report/embedquestion/classes/utils.php: call to report_embedquestion\utils::get_activity_link()
line 219 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\utils::get_embed_location_summary()
line 188 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\local\report\progress_report->display_attempt_summary()
line 80 of /report/embedquestion/activity.php: call to report_embedquestion\local\report\progress_report->display()

Thanks !

[pkgh]

Did another test after upgrading my localhost Moodle 3.11 to 3.11.9, released yesterday. Installed the latest available embed question plugins. Created a new question and embedded it in a Page context and in a Label context. The Page-embedded results report OK; for the Label case I get stuff like this:

Debug info: Unknown column 'ctx.id' in 'where clause'
SELECT COUNT(1) FROM mdl_report_embedquestion_attempt r
JOIN mdl_context cxt ON cxt.id = r.contextid

JOIN mdl_user u ON u.id = r.userid

JOIN mdl_question_usages qu ON qu.id = r.questionusageid
JOIN mdl_question_attempts qa ON qa.questionusageid = qu.id
JOIN mdl_question q ON q.id = qa.questionid
JOIN mdl_question_attempt_steps qas ON qa.id = qas.questionattemptid WHERE r.questionusageid = ?
AND (ctx.id = ? OR ctx.path LIKE ?)
AND r.userid = ?
[array (
0 => 15,
1 => 25,
2 => '/1/3/25/%',
3 => 4,
)]
Error code: dmlreadexception Stack trace:

line 486 of \lib\dml\moodle_database.php: dml_read_exception thrown
line 293 of \lib\dml\moodle_read_slave_trait.php: call to moodle_database->query_end()
line 1273 of \lib\dml\mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->query_end()
line 1671 of \lib\dml\moodle_database.php: call to mysqli_native_moodle_database->get_records_sql()
line 1744 of \lib\dml\moodle_database.php: call to moodle_database->get_record_sql()
line 1954 of \lib\dml\moodle_database.php: call to moodle_database->get_field_sql()
line 2036 of \lib\tablelib.php: call to moodle_database->count_records_sql()
line 2091 of \lib\tablelib.php: call to table_sql->query_db()
line 213 of \report\embedquestion\classes\local\report\progress_report.php: call to table_sql->out()
line 188 of \report\embedquestion\classes\local\report\progress_report.php: call to report_embedquestion\local\report\progress_report->display_attempt_summary()
line 83 of \report\embedquestion\index.php: call to report_embedquestion\local\report\progress_report->display()

Whether this can help or not, I called my category "Embeddable" and gave it the ID "embeddable_id".
My question is a Select missing words question with ID "embed_1".

The Page embed summary results produces links like:
/report/embedquestion/activity.php?cmid=38&userid=4&usageid=13

The Label summary results links have a different php file and a courseid param:
/report/embedquestion/index.php?courseid=2&userid=4&usageid=15
(could it be that the context id is missing / not processed properly?)

HTH.

[pkgh]

PS.
For admins and teachers, however, if they happen to answer the Label embeds, the report URL links look like:

/report/embedquestion/activity.php?cmid=2&userid=6&usageid=25

, so the php file and the first parameter appear the same as in the case of Page-embeds...

HOWEVER, such links lead to the error pages of the kind I reported earlier:
#13 (comment)

Today's example:

Notice: Trying to get property 'pageurl' of non-object in /ocfs2/www/test39/report/embedquestion/classes/utils.php on line 206
Notice: Trying to get property 'embedid' of non-object in /ocfs2/www/test39/report/embedquestion/classes/utils.php on line 207
Exception - Argument 1 passed to filter_embedquestion\embed_id::create_from_string() must be of the type string, null given, called in [dirroot]/report/embedquestion/classes/utils.php on line 207

More information about this error
Debug info:
Error code: generalexceptionmessage
Stack trace:

line 57 of /filter/embedquestion/classes/embed_id.php: TypeError thrown
line 207 of /report/embedquestion/classes/utils.php: call to filter_embedquestion\embed_id::create_from_string()
line 45 of /report/embedquestion/classes/utils.php: call to report_embedquestion\utils::get_activity_link()
line 219 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\utils::get_embed_location_summary()
line 188 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\local\report\progress_report->display_attempt_summary()
line 80 of /report/embedquestion/activity.php: call to report_embedquestion\local\report\progress_report->display()

(Maybe admin / teacher's previews should NOT be gathered in the reports ?)
Regardless, this still leaves open the proper handling of Label embed results as reported an hour ago based on students' attempts:
#13 (comment)

HTH

Przemek

[pkgh]

PS2. I'm facing exactly the same problems on my local Moodle 4.0.3 - Label embeds produce faulty report links which are different for student and admin/teacher attempts, but which both lead to error pages as described in my previous comments.

BTW the same errors as for Labels crop up when a question is embedded in a course section summary. I noticed that those attempts actually add to those collected from the labels. (Somehow, the same course level context is probably saved in the DB.)

Maybe the Atto button for embedding questions could be stopped from appearing in some contexts ... . One other such problem context could be activity descriptions (which I think clash with the embeds [of the same question] used within the activity itself). For example, the "atto_cloze" plugin button appears only when editing quiz questions of the "Cloze" type, even though the button is standardly added to Atto's toolbar in Atto's settings.)

Anyway, I'm surviving :) , but such are my current reports and thoughts.

[pkgh]

I think I have found the source of the problem - a typo in an SQL command :) .

File:
/report/embedquestion/classes/attempt_summary_table.php

Line: 195

Instead of:
JOIN {context} cxt ON cxt.id = r.contextid

Should be:
JOIN {context} ctx ON ctx.id = r.contextid

Since everywhere else it's "ctx" that you use as the alias , and not "cxt".

I have patched locally on one of my systems, and the error seems gone.

I am now getting a notice only:

Notice: Trying to get property 'id' of non-object in /report/embedquestion/classes/attempt_summary_table.php on line 150

which maybe stems from the fact that "cmid" is not recorded when the embed context is a course page (as in Labels) and not an activity / resource? That would be my wild guess.

Anyway, I can live with a warning if everything else works for an ordinary user.
I could try a pull request, but I have not really done this much, so I'm not taking the risk now ;) .
HTH.

[pkgh]

PS. That notice IS proving important, however. When clicking on the link to actually review an attempt made on a question embedded in a Label (a link such as /report/embedquestion/attemptdetail.php?cmid&attempt=64), I get:

Debug info:
SELECT c.*
FROM {course_modules} cm
JOIN {course} c ON c.id = cm.course
WHERE cm.id = ?
[array (
0 => 0,
)]
Error code: invalidrecordunknown Stack trace:

line 1674 of /lib/dml/moodle_database.php: dml_missing_record_exception thrown
line 2449 of /lib/modinfolib.php: call to moodle_database->get_record_sql()
line 34 of /report/embedquestion/attemptdetail.php: call to get_course_and_cm_from_cmid()

So the problem is perhaps only partially resolved for now.

================

Also unresolved remains the part about teachers attempts on questions embedded in Labels. Those still record faulty links that trigger:

Notice: Trying to get property 'pageurl' of non-object in .../report/embedquestion/classes/utils.php on line 206

Notice: Trying to get property 'embedid' of non-object in .../report/embedquestion/classes/utils.php on line 207

Exception - Argument 1 passed to filter_embedquestion\embed_id::create_from_string() must be of the type string, null given, called in [dirroot]/report/embedquestion/classes/utils.php on line 207

Error code: generalexceptionmessage
Stack trace:

line 57 of /filter/embedquestion/classes/embed_id.php: TypeError thrown
line 207 of /report/embedquestion/classes/utils.php: call to filter_embedquestion\embed_id::create_from_string()
line 45 of /report/embedquestion/classes/utils.php: call to report_embedquestion\utils::get_activity_link()
line 219 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\utils::get_embed_location_summary()
line 188 of /report/embedquestion/classes/local/report/progress_report.php: call to report_embedquestion\local\report\progress_report->display_attempt_summary()
line 80 of /report/embedquestion/activity.php: call to report_embedquestion\local\report\progress_report->display()

HTH.

[pkgh]

I have investigated a little more.

In the case of Labels and students' attempts, the "pageurl" recorded in the 'mdl_report_embedquestion_attempt' table is the course's address (hence sth like /course/view.php?id=2), and not the activity's. Thus, a label's ID is never collected, so it cannot be used. And labels generally are not treated like "activities", so far.

As a result, the links to detailed attempt views for attempts completed in labels simply lack the value of 'cmid':

/report/embedquestion/attemptdetail.php?cmid&attempt=33

and generate first a notice and then the error (on the attempt detail view), mentioned in my previous post.

I have tested and seen that if we enter the id value by hand, e.g.

cmid=50
(or whatever ID the label has, which can be viewed for example when editing it,, or from the id="module-50" parameter of the li element of the course page)

then the detailed attempt view page loads correctly
(the retrieved name of the Label may contain a part of the embed code, but that's perhaps not a problem).

Example below:

The question is: Is it possible to collect labels' IDs, somehow, e.g. by recording the edit page's URL, alongside the current pageurl variable (such editing pages look like /course/modedit.php?update=1238&return=0&sr=0), so there is a recognisable "update=1238" part ? The edit pages are those that get saved before the Label with the embedded question is shown. Also, as mentioned, labels have id numbers indicated in the "module-" id parameter of the li element on the course page, e.g. <li class="activity label modtype_label hasinfo" id="module-4">

For now, as a workaround on my side, to prevent those bad links to detailed views for Labels, I have disabled links containing an empty cmid with such CSS:

body#page-report-embedquestion-index a[href*="?cmid&"] {pointer-events: none;}

========

The above concerned students' attempts. In the case of teachers completing embedded questions in labels, the plugin code interestingly chooses the activity path for recording the URL, thus the report offers summary links like

/report/embedquestion/activity.php?cmid=2&userid=6&usageid=25
(so somehow cmid's availability is incorrectly assumed, where the value is that of the course id)

When we correct the above by hand to:

/report/embedquestion/index.php?courseid=2&userid=6&usageid=25

then the teacher's summary attempt page loads correctly, though with the same notice as for students:

"Notice: Trying to get property 'id' of non-object in .../report/embedquestion/classes/attempt_summary_table.php on line 150"

Apparently, for teachers the context for a label is differently detected by the code, likely because of some extra capability check somewhere..
My coding skills are nil, so I can't state anything more.

HTH.

[timhunt]

Thanks for all the investigation. I think you are pionting in the right direction with some of it.

The cxt / ctx difference is not relevant in this query. The 'wrong' table alias is used consistnetly in that query. (Would still be good to fix one day.

The URL stored in the database is meant to be the the URL where the question was embedded, whatever that was, so what is being stored in the databse is correct.

Teh thing that is wrong is the repot making assumptions about the possible URls that can be used, and what the parameters in them mean. Yes, now that I look at it, the get_attempt_summary_link function in report_embedquestion\utils is just garbage, or to be more polite, only works with a very few possible embed locations.