Skip to content

Commit c90955f

Browse files
authored
Merge pull request #13 from xymoryn/fix/firefox-popup-sizing
Resolve Firefox popup sizing issues
2 parents e6d0714 + a92d4ec commit c90955f

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

src/ui/popup/body/style.less

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
}
115115

116116
html:not(.mobile) {
117-
width: calc(@popup-content-width + 2 * @popup-content-padding + 4px);
117+
width: @popup-total-width;
118118
}
119119

120120
.Logo {

src/ui/popup/style.less

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@
55
@popup-content-height: 20rem;
66
@popup-content-padding: 0.5rem;
77

8+
// Total dimensions including padding (for border-box)
9+
@popup-total-width: @popup-content-width + 2 * @popup-content-padding;
10+
@popup-total-height: @popup-content-height + 2 * @popup-content-padding;
11+
812
@import "./components/custom-settings-toggle/style";
913
@import "./components/engine-switch/style";
1014
@import "./components/filter-settings/style";
@@ -16,14 +20,14 @@
1620

1721
body {
1822
align-items: center;
19-
box-sizing: content-box;
23+
box-sizing: border-box;
2024
display: flex;
2125
flex-direction: column;
22-
height: @popup-content-height;
26+
min-height: @popup-total-height;
2327
margin: 0 auto;
2428
padding: @popup-content-padding;
2529
position: relative;
26-
width: @popup-content-width;
30+
width: @popup-total-width;
2731
}
2832

2933
.header {
@@ -219,9 +223,10 @@ footer {
219223
// Make popup borders the same
220224
// across platforms and browser versions
221225

222-
html:not(.mobile):not(.preview) body {
223-
height: @popup-content-height + 4rem;
224-
}
226+
// Removed: height is now properly set in body with border-box
227+
// html:not(.mobile):not(.preview) body {
228+
// height: @popup-content-height + 4rem;
229+
// }
225230

226231
.overlay {
227232
height: calc(100% - 4px);

0 commit comments

Comments
 (0)