internal: Fix linting issues.

milesj · milesj · commit 0ff85e293cc9 · 2025-03-13T11:29:20.000-07:00
diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
     "packages/*"
   ],
   "devDependencies": {
-    "@babel/core": "^7.26.9",
+    "@babel/core": "^7.26.10",
     "@moonrepo/cli": "^1.30.0",
     "@moonrepo/dev": "workspace:*",
     "eslint": "^9.22.0",
diff --git a/packages/babel-preset/package.json b/packages/babel-preset/package.json
@@ -46,7 +46,7 @@
     "babel-preset-solid": "^1.9.5"
   },
   "devDependencies": {
-    "@babel/core": "^7.26.9"
+    "@babel/core": "^7.26.10"
   },
   "funding": {
     "type": "ko-fi",
diff --git a/packages/dev/src/helpers.ts b/packages/dev/src/helpers.ts
@@ -15,7 +15,7 @@ export function parseJson<T>(filePath: string): T {
 }
 
 export function parseVersion(version: string): number {
-	return Number.parseFloat(version.replace(/[^\d.]+/g, ''));
+	return Number.parseFloat(version.replaceAll(/[^\d.]+/g, ''));
 }
 
 // PACKAGE.JSON
diff --git a/packages/eslint-config/package.json b/packages/eslint-config/package.json
@@ -35,8 +35,8 @@
   "dependencies": {
     "@eslint/compat": "^1.2.7",
     "@moonrepo/dev": "^3.0.2",
-    "@typescript-eslint/eslint-plugin": "^8.26.0",
-    "@typescript-eslint/parser": "^8.26.0",
+    "@typescript-eslint/eslint-plugin": "^8.26.1",
+    "@typescript-eslint/parser": "^8.26.1",
     "eslint-config-airbnb-base": "^15.0.0",
     "eslint-config-prettier": "^10.1.1",
     "eslint-plugin-compat": "^6.0.2",
diff --git a/packages/eslint-config/src/async.ts b/packages/eslint-config/src/async.ts
@@ -4,6 +4,7 @@ import promisePlugin from 'eslint-plugin-promise';
 
 const config: eslint.Linter.Config = {
 	name: 'moon:async',
+	// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 	plugins: { promise: promisePlugin },
 	rules: {
 		'promise/param-names': 'error',
diff --git a/packages/eslint-config/src/browser.ts b/packages/eslint-config/src/browser.ts
@@ -1,7 +1,7 @@
 import type eslint from 'eslint';
-import { CONFIGS_LIST, TESTS_LIST } from '@moonrepo/dev';
 import compatPlugin from 'eslint-plugin-compat';
 import globals from 'globals';
+import { CONFIGS_LIST, TESTS_LIST } from '@moonrepo/dev';
 
 const config: eslint.Linter.Config = {
 	name: 'moon:browser',
diff --git a/packages/eslint-config/src/jest.ts b/packages/eslint-config/src/jest.ts
@@ -1,6 +1,6 @@
 import type eslint from 'eslint';
-import { EXTENSIONS_PATTERN, TESTS_LIST } from '@moonrepo/dev';
 import jestPlugin from 'eslint-plugin-jest';
+import { EXTENSIONS_PATTERN, TESTS_LIST } from '@moonrepo/dev';
 
 const jestConfig: eslint.Linter.Config = {
 	name: 'moon:jest',
diff --git a/packages/eslint-config/src/module.ts b/packages/eslint-config/src/module.ts
@@ -1,19 +1,20 @@
 import { builtinModules } from 'module';
 import type eslint from 'eslint';
+// @ts-expect-error Not typed
+import * as importPlugin from 'eslint-plugin-import';
+import simpleImportSortPlugin from 'eslint-plugin-simple-import-sort';
 import {
 	CONFIGS_LIST,
 	EXTENSIONS,
 	IGNORE_LIST,
 	NON_JS_REGEX,
 	TS_PATH_PREFIX_REGEX,
 } from '@moonrepo/dev';
-// @ts-expect-error Not typed
-import * as importPlugin from 'eslint-plugin-import';
-import simpleImportSortPlugin from 'eslint-plugin-simple-import-sort';
 
 const config: eslint.Linter.Config = {
 	name: 'moon:module',
 	plugins: {
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		import: importPlugin,
 		'simple-import-sort': simpleImportSortPlugin,
 	},
diff --git a/packages/eslint-config/src/node.ts b/packages/eslint-config/src/node.ts
@@ -1,6 +1,6 @@
 import type eslint from 'eslint';
-import nodePlugin from 'eslint-plugin-n';
 import compatPlugin from 'eslint-plugin-compat';
+import nodePlugin from 'eslint-plugin-n';
 import globals from 'globals';
 
 const config: eslint.Linter.Config = {
diff --git a/packages/eslint-config/src/react.ts b/packages/eslint-config/src/react.ts
@@ -1,11 +1,11 @@
 import type eslint from 'eslint';
-import { CASE_SENSITIVE, getPackageVersion } from '@moonrepo/dev';
 // @ts-expect-error Not typed
 import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';
 import reactPlugin from 'eslint-plugin-react';
 import reactHooksPlugin from 'eslint-plugin-react-hooks';
 // @ts-expect-error Not typed
 import reactPerfPlugin from 'eslint-plugin-react-perf';
+import { CASE_SENSITIVE, getPackageVersion } from '@moonrepo/dev';
 import browserConfig from './browser';
 
 const reactVersion = getPackageVersion('react');
@@ -21,9 +21,11 @@ const reactConfig: eslint.Linter.Config = {
 		},
 	},
 	plugins: {
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		'jsx-a11y': jsxA11yPlugin,
 		react: reactPlugin,
 		'react-hooks': reactHooksPlugin,
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		'react-perf': reactPerfPlugin,
 	},
 	settings: {
@@ -302,7 +304,8 @@ const testsConfig: eslint.Linter.Config = {
 // to TSX files. Not the entire codebase.
 export default [
 	browserConfig,
-	jsxA11yPlugin.configs.recommended,
+	// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
+	jsxA11yPlugin.flatConfigs.recommended,
 	reactConfig,
 	hooksConfig,
 	testsConfig,
diff --git a/packages/eslint-config/src/solid.ts b/packages/eslint-config/src/solid.ts
@@ -1,17 +1,18 @@
 import type eslint from 'eslint';
 import solidPlugin from 'eslint-plugin-solid';
+// import { type FixupPluginDefinition,fixupPluginRules } from '@eslint/compat';
 import browserConfig from './browser';
 
 const solidConfig: eslint.Linter.Config = {
 	name: 'moon:solid',
 	files: ['**/*.ts', '**/*.tsx'],
-	// @ts-expect-error Not typed
-	plugins: { solid: solidPlugin },
-	parserOptions: {
-		ecmaFeatures: {
-			jsx: true,
+	languageOptions: {
+		parserOptions: {
+			ecmaFeatures: {
+				jsx: true,
+			},
 		},
 	},
 };
 
-export default [browserConfig, solidPlugin.configs.typescript, solidConfig];
+export default [...browserConfig, solidPlugin.configs['flat/typescript'], solidConfig];
diff --git a/packages/eslint-config/src/tests.ts b/packages/eslint-config/src/tests.ts
@@ -1,6 +1,6 @@
 import type eslint from 'eslint';
-import { EXTENSIONS_PATTERN, TESTS_LIST } from '@moonrepo/dev';
 import globals from 'globals';
+import { EXTENSIONS_PATTERN, TESTS_LIST } from '@moonrepo/dev';
 
 const testsConfig: eslint.Linter.Config = {
 	name: 'moon:tests',
diff --git a/packages/eslint-config/src/typescript.ts b/packages/eslint-config/src/typescript.ts
@@ -1,3 +1,4 @@
+/* eslint-disable import/no-unresolved */
 import type eslint from 'eslint';
 // import { getTsProjectForEslint } from '@moonrepo/dev';
 import tsPlugin from '@typescript-eslint/eslint-plugin';
@@ -7,6 +8,7 @@ import * as tsParser from '@typescript-eslint/parser';
 const config: eslint.Linter.Config = {
 	name: 'moon:typescript',
 	languageOptions: {
+		// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
 		parser: tsParser,
 		parserOptions: {
 			projectService: true,
diff --git a/packages/eslint-config/src/unicorn.ts b/packages/eslint-config/src/unicorn.ts
@@ -1,6 +1,6 @@
 import type eslint from 'eslint';
-import { CONFIGS_LIST } from '@moonrepo/dev';
 import unicornPlugin from 'eslint-plugin-unicorn';
+import { CONFIGS_LIST } from '@moonrepo/dev';
 
 const config: eslint.Linter.Config = {
 	name: 'moon:unicorn',
diff --git a/packages/vscode-extension/package.json b/packages/vscode-extension/package.json
@@ -355,7 +355,7 @@
     "@types/semver": "^7.5.8",
     "@types/vscode": "1.77.0",
     "@vscode/test-electron": "^2.4.1",
-    "esbuild": "^0.25.0",
+    "esbuild": "^0.25.1",
     "vsce": "^2.15.0"
   }
 }
diff --git a/packages/vscode-extension/src/lastRunView.ts b/packages/vscode-extension/src/lastRunView.ts
@@ -54,7 +54,7 @@ export class LastRunProvider implements vscode.WebviewViewProvider {
 		}
 
 		const content = comments
-			.map((comment) => comment.replace(/\*\*(\w+)\*\*/g, (_, match) => `<b>${match}</b>`))
+			.map((comment) => comment.replaceAll(/\*\*(\w+)\*\*/g, (_, match) => `<b>${match}</b>`))
 			.join(', ');
 
 		return `| ${content}`;
diff --git a/packages/vscode-extension/src/workspace.ts b/packages/vscode-extension/src/workspace.ts
@@ -219,7 +219,7 @@ export class Workspace {
 			// Output is: moon 0.0.0
 			const parts = result.split(' ');
 
-			return parts[parts.length - 1];
+			return parts.at(-1)!;
 		} catch {
 			return '0.0.0';
 		}
diff --git a/yarn.lock b/yarn.lock

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,7 @@ export function parseJson<T>(filePath: string): T {`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`export function parseVersion(version: string): number {`
`18`		`- return Number.parseFloat(version.replace(/[^\d.]+/g, ''));`
	`18`	`+ return Number.parseFloat(version.replaceAll(/[^\d.]+/g, ''));`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`// PACKAGE.JSON`