Skip to content

Commit 07d8380

Browse files
Merge pull request #1171 from moonstream-to/fix-deleting-logic
Update delete subscriptions.
2 parents 6376d97 + 9dfe09e commit 07d8380

File tree

2 files changed

+6
-27
lines changed

2 files changed

+6
-27
lines changed

moonstreamapi/moonstreamapi/actions.py

Lines changed: 5 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -611,39 +611,18 @@ def delete_seer_subscription(
611611
) -> None:
612612
"""
613613
Delete seer subscription from db
614-
If there are no more subscriptions for this address,abi_selector delete all abis
615614
"""
616-
617-
## Delete subscription from db
618-
615+
### TEMPORARY disable deleting abi jobs from db
616+
### TODO(ANDREY): fix this
619617
try:
620-
db_session.query(AbiSubscriptions).filter(
618+
db_session.query(AbiSubscriptions).filter(
621619
AbiSubscriptions.subscription_id == subscription_id
622620
).delete(synchronize_session=False)
623621
db_session.commit()
624622
except Exception as e:
625-
logger.error(f"Error delete subscription from db: {str(e)}")
623+
logger.error(f"Error deleting subscription from db: {str(e)}")
626624
db_session.rollback()
627-
628-
not_connected_abi_jobs = (
629-
db_session.query(AbiJobs)
630-
.join(AbiSubscriptions, AbiJobs.id == AbiSubscriptions.abi_job_id, isouter=True)
631-
.filter(AbiSubscriptions.subscription_id == None)
632-
.cte("not_connected_abi_jobs")
633-
)
634-
635-
## Delete abi jobs from db
636-
637-
try:
638-
db_session.query(AbiJobs).filter(
639-
AbiJobs.id.in_(db_session.query(not_connected_abi_jobs.c.id))
640-
).delete(synchronize_session=False)
641-
642-
db_session.commit()
643-
except Exception as e:
644-
logger.error(f"Error delete abi jobs from db: {str(e)}")
645-
db_session.rollback()
646-
625+
return
647626

648627
def add_abi_to_db(
649628
db_session: Session,

moonstreamapi/moonstreamapi/version.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
Moonstream library and API version.
33
"""
44

5-
MOONSTREAMAPI_VERSION = "0.4.11"
5+
MOONSTREAMAPI_VERSION = "0.4.12"

0 commit comments

Comments
 (0)