Fix linting issues (#113)

moorara · web-flow · commit 72ce1364f616 · 2025-06-25T15:24:09.000-04:00
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -0,0 +1,7 @@
+version: "2"
+linters:
+  settings:
+    staticcheck:
+      checks:
+        - all
+        - '-QF1008' # disable the rule QF1008
diff --git a/cli/cli.go b/cli/cli.go
@@ -0,0 +1,2 @@
+// Package cli configures the command line application.
+package cli
diff --git a/cli/common_test.go b/cli/common_test.go
@@ -393,7 +393,7 @@ func TestResolveByName(t *testing.T) {
 			c := resolveByName(test.name)
 			assert.Equal(t, test.expectedCert, c)
 
-			os.Remove(test.keyFile)
+			assert.NoError(t, os.Remove(test.keyFile))
 		})
 	}
 }
diff --git a/cli/helper_test.go b/cli/helper_test.go
@@ -23,7 +23,8 @@ func newMockUI(r io.Reader) *mockUI {
 }
 
 func (u *mockUI) Ask(query string) (string, error) {
-	fmt.Fprint(u.MockUi.OutputWriter, query)
+	_, _ = fmt.Fprint(u.MockUi.OutputWriter, query)
+
 	line, err := u.reader.ReadString('\n')
 	if err != nil {
 		return "", err
diff --git a/go.mod b/go.mod
@@ -1,6 +1,6 @@
 module github.com/moorara/gocert
 
-go 1.22.2
+go 1.24.4
 
 require (
 	github.com/BurntSushi/toml v1.5.0
@@ -30,6 +30,6 @@ require (
 	github.com/posener/complete v1.1.1 // indirect
 	github.com/shopspring/decimal v1.2.0 // indirect
 	github.com/spf13/cast v1.3.1 // indirect
-	golang.org/x/crypto v0.31.0 // indirect
-	golang.org/x/sys v0.28.0 // indirect
+	golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a // indirect
+	golang.org/x/sys v0.0.0-20190412213103-97732733099d // indirect
 )
diff --git a/go.sum b/go.sum
@@ -53,14 +53,12 @@ github.com/stretchr/testify v1.10.0 h1:Xv5erBjTwe/5IxqUQTdXv5kgmIvbHo3QQyRwhJsOf
 github.com/stretchr/testify v1.10.0/go.mod h1:r2ic/lqez/lEtzL7wO/rwa5dbSLXVDPFyf8C91i36aY=
 golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w=
 golang.org/x/crypto v0.0.0-20200414173820-0848c9571904/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
+golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a h1:vclmkQCjlDX5OydZ9wv8rBCcS0QyQY66Mpf/7BZbInM=
 golang.org/x/crypto v0.0.0-20200820211705-5c72a883971a/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
-golang.org/x/crypto v0.31.0 h1:ihbySMvVjLAeSH1IbfcRTkD/iNscyz8rGzjF/E5hV6U=
-golang.org/x/crypto v0.31.0/go.mod h1:kDsLvtWBEx7MV9tJOj9bnXsPbxwJQ6csT/x4KIN4Ssk=
 golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
 golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
+golang.org/x/sys v0.0.0-20190412213103-97732733099d h1:+R4KGOnez64A81RvjARKc4UT5/tI9ujCIVX+P5KiHuI=
 golang.org/x/sys v0.0.0-20190412213103-97732733099d/go.mod h1:h1NjWce9XRLGQEsW7wpKNCjG9DtNlClVuFLEZdDNbEs=
-golang.org/x/sys v0.28.0 h1:Fksou7UEQUWlKvIdsqzJmUmCX3cZuD2+P3XyyzwMhlA=
-golang.org/x/sys v0.28.0/go.mod h1:/VUhepiaJMQUp4+oa/7Zr1D23ma6VTLIYjOOTFZPUcA=
 golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405 h1:yhCVgyC4o1eVCa2tZl7eS0r+SDo693bJlVdllGtEeKM=
 gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0=
diff --git a/metadata/metadata.go b/metadata/metadata.go
@@ -1,3 +1,4 @@
+// Package metadata provides information about the application build.
 package metadata
 
 import "fmt"
diff --git a/pki/manager.go b/pki/manager.go
@@ -34,7 +34,7 @@ func NewX509Manager() Manager {
 
 func checkName(name string) error {
 	if name == "" {
-		return errors.New("Name is not set")
+		return errors.New("name is not set")
 	}
 
 	pattern := "./*/" + name + ".*"
@@ -91,7 +91,7 @@ func (m *x509Manager) GenCert(config Config, claim Claim, c Cert) error {
 		EmailAddresses: claim.EmailAddress,
 
 		BasicConstraintsValid: true,
-		IsCA: true,
+		IsCA:                  true,
 
 		SubjectKeyId:   subjectKeyID,
 		AuthorityKeyId: subjectKeyID,
@@ -284,7 +284,7 @@ func (m *x509Manager) SignCSR(configCA Config, cCA Cert, configCSR Config, cCSR
 // VerifyCert verifies a certificate using a ceritifcate authority
 func (m *x509Manager) VerifyCert(cCA, c Cert, dnsName string) error {
 	if cCA.Type != CertTypeRoot && cCA.Type != CertTypeInterm {
-		return errors.New("Certificate authority is invalid")
+		return errors.New("certificate authority is invalid")
 	}
 
 	chain, err := readCertificateChain(cCA.ChainPath())
diff --git a/pki/pki.go b/pki/pki.go
@@ -1,3 +1,4 @@
+// Package pki provides functions to generate and manage certificates and certificate requests.
 package pki
 
 import (
@@ -184,7 +185,7 @@ func readCertificateRequest(path string) (*x509.CertificateRequest, error) {
 func writeCertificateChain(c, cCA Cert) error {
 	// Only an intermediate ca needs a certificate chain
 	if c.Type != CertTypeInterm {
-		return errors.New("Only intermediate CAs have certificate chain")
+		return errors.New("only intermediate CAs have certificate chain")
 	}
 
 	// CA can only be root or another intermediate
diff --git a/pki/pki_test.go b/pki/pki_test.go
diff --git a/util/file.go b/util/file.go
@@ -34,7 +34,7 @@ func MkDirs(basePath string, dirs ...string) (func(), error) {
 	items := make([]string, 0)
 	deleteFunc := func() {
 		for _, item := range items {
-			os.RemoveAll(item)
+			_ = os.RemoveAll(item)
 		}
 	}
 
@@ -71,7 +71,7 @@ func CreateTempFile(content string) (string, func(), error) {
 
 	filePath := file.Name()
 	deleteFunc := func() {
-		os.Remove(filePath)
+		_ = os.Remove(filePath)
 	}
 
 	return filePath, deleteFunc, nil
diff --git a/util/reflect_test.go b/util/reflect_test.go
@@ -48,7 +48,7 @@ func newMockUI(r io.Reader) *mockUI {
 }
 
 func (u *mockUI) Ask(query string) (string, error) {
-	fmt.Fprint(u.MockUi.OutputWriter, query)
+	_, _ = fmt.Fprint(u.MockUi.OutputWriter, query)
 	line, err := u.reader.ReadString('\n')
 	if err != nil {
 		return "", err
diff --git a/util/std.go b/util/std.go
@@ -78,7 +78,8 @@ func PipeStdout() (outR, outW *os.File, restore func(), err error) {
 func ReadFromStdoutPipe(outR, outW *os.File, str string) (string, error) {
 	var buf bytes.Buffer
 
-	fmt.Fprint(os.Stdout, str)
+	_, _ = fmt.Fprint(os.Stdout, str)
+
 	err := outW.Close()
 	if err != nil {
 		return "", err
diff --git a/util/std_test.go b/util/std_test.go
@@ -105,8 +105,8 @@ func TestPipeStdoutAndStderr(t *testing.T) {
 		r, w, restore, err := PipeStdoutAndStderr()
 		assert.NoError(t, err)
 
-		fmt.Fprint(os.Stdout, tc.out)
-		fmt.Fprint(os.Stderr, tc.err)
+		_, _ = fmt.Fprint(os.Stdout, tc.out)
+		_, _ = fmt.Fprint(os.Stderr, tc.err)
 
 		err = w.Close()
 		assert.NoError(t, err)
diff --git a/util/util.go b/util/util.go
@@ -0,0 +1,2 @@
+// Package util provides common utility functions.
+package util

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	`+// Package cli configures the command line application.`
	`2`	`+package cli`
Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ func TestResolveByName(t *testing.T) {`
`393`	`393`	`c := resolveByName(test.name)`
`394`	`394`	`assert.Equal(t, test.expectedCert, c)`
`395`	`395`
`396`		`- os.Remove(test.keyFile)`
	`396`	`+ assert.NoError(t, os.Remove(test.keyFile))`
`397`	`397`	`})`
`398`	`398`	`}`
`399`	`399`	`}`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,8 @@ func newMockUI(r io.Reader) *mockUI {`
`23`	`23`	`}`
`24`	`24`
`25`	`25`	`func (u *mockUI) Ask(query string) (string, error) {`
`26`		`- fmt.Fprint(u.MockUi.OutputWriter, query)`
	`26`	`+ _, _ = fmt.Fprint(u.MockUi.OutputWriter, query)`
	`27`	`+`
`27`	`28`	`line, err := u.reader.ReadString('\n')`
`28`	`29`	`if err != nil {`
`29`	`30`	`return "", err`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+// Package metadata provides information about the application build.`
`1`	`2`	`package metadata`
`2`	`3`
`3`	`4`	`import "fmt"`