Merge pull request #1736 from moov-io/fix-issue1735

test/issues: add code from Issue 1735

Author: adamdecaf

batch.go

@@ -307,7 +307,15 @@ func (batch *Batch) SetValidation(opts *ValidateOpts) {
 	if batch == nil {
 		return
 	}
+
 	batch.validateOpts = opts
+
+	if batch.Header != nil {
+		batch.Header.SetValidation(opts)
+	}
+	if batch.Control != nil {
+		batch.Control.SetValidation(opts)
+	}
 }
 
 // verify checks basic valid NACHA batch rules. Assumes properly parsed records. This does not mean it is a valid batch as validity is tied to each batch type

test/issues/issue1735_test.go

@@ -0,0 +1,54 @@
+package issues
+
+import (
+	"testing"
+
+	"github.com/moov-io/ach"
+)
+
+func TestIssue1735_ValidateOptsNotPropagated(t *testing.T) {
+// Test that ValidateOpts are propagated when creating a file from JSON.
+	jsonData := []byte(`{
+		"fileHeader": {
+			"immediateOrigin": "022083649",
+			"immediateDestination": "011000015",
+			"fileCreationDate": "260120",
+			"fileCreationTime": "1030",
+			"fileIDModifier": "A"
+		},
+		"batches": [{
+			"batchHeader": {
+				"serviceClassCode": 220,
+				"companyName": "Test Company ©",
+				"companyIdentification": "54321",
+				"standardEntryClassCode": "WEB",
+				"companyEntryDescription": "Payment",
+				"effectiveEntryDate": "260127",
+				"originatorStatusCode": 1,
+				"ODFIIdentification": "123456780",
+				"batchNumber": 1
+			},
+			"entryDetails": [{
+				"transactionCode": 21,
+				"RDFIIdentification": "98765432",
+				"checkDigit": "0",
+				"DFIAccountNumber": "665544",
+				"amount": 111111,
+				"identificationNumber": "Test",
+				"individualName": "John Doe",
+				"traceNumber": "12345678123456"
+			}]
+		}]
+	}`)
+
+	// Create ValidateOpts with AllowSpecialCharacters
+	validateOpts := &ach.ValidateOpts{
+		AllowSpecialCharacters: true,
+	}
+
+	// This should succeed but fails
+	_, err := ach.FileFromJSONWith(jsonData, validateOpts)
+	if err != nil {
+		t.Fatalf("Expected success, got error: %v", err)
+	}
+}