Skip to content

Commit 0e07dc2

Browse files
committed
Improvements for expiry package
1 parent 7dd7f6e commit 0e07dc2

File tree

7 files changed

+24
-27
lines changed

7 files changed

+24
-27
lines changed

.github/workflows/monorepo-split-packages.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77

88
env:
99
GITHUB_TOKEN: ${{ secrets.BOT }}
10-
CORE_VERSION: "^3.0.2"
10+
CORE_VERSION: "^3.0.3"
1111

1212
jobs:
1313
packages_split:
@@ -42,13 +42,13 @@ jobs:
4242
steps:
4343
- uses: actions/checkout@v4
4444

45-
# Search and replace "moox/core": "*" with "moox/core": "^3.0.2" in composer.json
45+
# Search and replace "moox/core": "*" with "moox/core": "^3.0.3" in composer.json
4646
- name: Replace core version in composer.json
4747
working-directory: packages/${{ matrix.package }}
4848
run: |
4949
if [ -f composer.json ]; then
5050
echo "Updating moox/core version in ${{ matrix.package }}"
51-
sed -i 's/"moox\/core": "\*"/"moox\/core": "^3.0.2"/g' composer.json
51+
sed -i 's/"moox\/core": "\*"/"moox\/core": "^3.0.3"/g' composer.json
5252
fi
5353
5454
# Commit the updated composer.json (if there was a change)
@@ -59,7 +59,7 @@ jobs:
5959
git config --global user.name "mooxbot"
6060
git config --global user.email "[email protected]"
6161
git add composer.json
62-
git commit -m "Update moox/core dependency to ^^3.0.2" || echo "No changes to commit"
62+
git commit -m "Update moox/core dependency to ^^3.0.3" || echo "No changes to commit"
6363
fi
6464
6565
- if: "!startsWith(github.ref, 'refs/tags/')"

packages/core/resources/lang/de/expiry.php

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,17 @@
1313
'update_expiries' => 'Ablaufdaten aktualisieren',
1414
'updating_started' => 'Aktualisieren gestartet',
1515

16-
'expired_at' => 'Abgelaufen',
16+
'expired_at' => 'Fällig',
1717
'processing_deadline' => 'Bearbeitungsfrist',
18-
'escalated_at' => 'Eskaliert am',
19-
'escalated_to' => 'Eskaliert an',
18+
'escalated_at' => 'Erinnerung',
19+
'escalated_to' => 'Erinnerung an',
2020
'cycle' => 'Turnus',
2121
'notifyUser' => 'Verantwortlicher',
2222
'expiry_job' => 'Typ',
2323

24-
'escalated_entries_in_expiry_dashboard' => 'Eskalierte Einträge im Expiry Dashboard',
25-
'following_escalated_entries' => 'Folgende Einträge sind eskaliert:',
26-
'will_expire_at' => 'Läuft ab am',
27-
'review_entreis' => 'Bitte überprüfen Sie diese Einträge so bald wie möglich im ',
24+
'escalated_entries_in_expiry_dashboard' => 'Erinnerung an zu bearbeitende Einträge',
25+
'following_escalated_entries' => 'Folgende Einträge stehen zur Bearbeitung an',
26+
'review_entries' => 'Bitte überprüfen Sie diese Einträge so bald wie möglich im ',
2827
'expiry_dashboard' => 'Ablaufdaten Dashboard',
2928

3029
'set_date_based_on_cycle' => 'Neues Ablaufdatum setzen basierend auf dem Turnus',

packages/core/resources/lang/en/expiry.php

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -17,18 +17,17 @@
1717
'update_expiries' => 'Update Expiries',
1818
'updating_started' => 'Updating started',
1919

20-
'expired_at' => 'Expired',
20+
'expired_at' => 'Due',
2121
'processing_deadline' => 'Processing deadline',
22-
'escalated_at' => 'Escalated at',
23-
'escalated_to' => 'Escalated to',
22+
'escalated_at' => 'Reminder',
23+
'escalated_to' => 'Reminder to',
2424
'cycle' => 'Cycle',
2525
'notifyUser' => 'Assignee',
2626
'expiry_job' => 'Type',
2727

28-
'escalated_entries_in_expiry_dashboard' => 'Escalated entries in the expiry dashboard',
29-
'following_escalated_entries' => 'The following entries have been escalated:',
30-
'will_expire_at' => 'Will expire at',
31-
'review_entreis' => 'Please review these entries as soon as possible in the ',
28+
'escalated_entries_in_expiry_dashboard' => 'Escalated entries in expiry dashboard',
29+
'following_escalated_entries' => 'Following entries are escalated',
30+
'review_entries' => 'Please review these entries as soon as possible in the ',
3231
'expiry_dashboard' => 'Expiry Dashboard',
3332

3433
'set_date_based_on_cycle' => 'Set date based on cycle',

packages/expiry/resources/views/emails/escalated_expiries.blade.php

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
}
6969
7070
.table .escalation {
71-
color: #e53e3e;
71+
color: #e5be01;
7272
font-weight: bold;
7373
}
7474
@@ -101,8 +101,7 @@
101101
<div class="logo">
102102
<img src="{{ $logoUrl }}" alt="Company Logo" class="w-24 h-auto">
103103
</div>
104-
<h1>{{ __('core::expiry.escalated_entries_in_expiry_dashboard') }}</h1>
105-
<h4>{{ __('core::expiry.following_escalated_entries') }}</h4>
104+
<h1>{{ __('core::expiry.following_escalated_entries') }}</h1>
106105

107106
<!-- Escalated Entries -->
108107
<table class="table">
@@ -111,7 +110,7 @@
111110
<th>{{ __('core::core.title') }}</th>
112111
<th>{{ __('core::expiry.notifyUser') }}</th>
113112
<th>{{ __('core::core.category') }}</th>
114-
<th>{{ __('core::expiry.will_expire_at') }}</th>
113+
<th>{{ __('core::expiry.expired_at') }}</th>
115114
<th>{{ __('core::expiry.processing_deadline') }}</th>
116115
<th>{{ __('core::expiry.escalated_at') }}</th>
117116
</tr>
@@ -133,7 +132,7 @@
133132
<br>
134133

135134
<!-- Footer -->
136-
<p class="footer">{{ __('core::expiry.review_entreis') }}<a
135+
<p class="footer">{{ __('core::expiry.review_entries') }}<a
137136
href="{{ url($panelPath . '/expiries') }}">{{ __('core::expiry.expiry_dashboard') }}</a>.</p>
138137
</div>
139138
</body>

packages/expiry/src/Jobs/SendEscalatedExpiriesJob.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ public function handle()
4242
'escalatedEntries' => $escalatedEntries->map(function ($entry) {
4343
return [
4444
'title' => $entry->title,
45-
'expired_at' => Carbon::parse($entry->expired_at)->format('d.m.Y'),
46-
'processing_deadline' => Carbon::parse($entry->processing_deadline)->format('d.m.Y'),
45+
'expired_at' => Carbon::parse($entry->expired_at)->diffForHumans(),
46+
'processing_deadline' => Carbon::parse($entry->processing_deadline)->diffForHumans(),
4747
'escalated_at' => Carbon::parse($entry->escalated_at)->format('d.m.Y'),
4848
'notified_to' => config('expiry.user_model')::where('ID', $entry->notified_to)->first()?->display_name,
4949
'user_email' => config('expiry.user_model')::where('ID', $entry->notified_to)->first()?->email,

packages/expiry/src/Mail/EscalatedExpiriesMail.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public function build()
2525
$logoPath = config('expiry.logo_url');
2626
$logoUrl = asset($logoPath);
2727

28-
return $this->subject('Eskalierte Einträge in den Ablaufdaten')
28+
return $this->subject(__('core::expiry.escalated_entries_in_expiry_dashboard'))
2929
->view('expiry::emails.escalated_expiries')
3030
->with([
3131
'escalatedEntries' => $this->entries['escalatedEntries'],

packages/expiry/src/Resources/ExpiryResource.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ class ExpiryResource extends Resource
2323

2424
protected static ?string $model = Expiry::class;
2525

26-
protected static ?string $navigationIcon = 'gmdi-access-time-o';
26+
protected static ?string $navigationIcon = 'gmdi-view-timeline-o';
2727

2828
protected static ?string $recordTitleAttribute = 'title';
2929

0 commit comments

Comments
 (0)