translation unique slug

Author: Kim-the-Diamond

packages/tag/composer.json

@@ -22,9 +22,7 @@
     },
     "autoload": {
         "psr-4": {
-            "Moox\\Tag\\": "src",
-            "Moox\\Tag\\Database\\Factories\\": "database/factories",
-            "Moox\\Tag\\Database\\Seeders\\": "database/seeders"
+            "Moox\\Tag\\": "src/"
         }
     },
     "extra": {

packages/tag/database/migrations/create_tag_translations.php.stub

@@ -20,10 +20,10 @@ return new class extends Migration
             $table->text('content')->nullable();
 
             // Ensure slug is unique per locale
-            $table->unique(['slug', 'locale'], 'unique_slug_per_locale');
+            $table->unique(['slug', 'locale']);
 
             // Ensure one translation per locale per tag
-            $table->unique(['tag_id', 'locale'], 'unique_translation_per_locale');
+            $table->unique(['tag_id', 'locale']);
 
             // Foreign key constraint
             $table->foreign('tag_id')

packages/tag/src/Models/Tag.php

@@ -45,36 +45,47 @@ class Tag extends Model implements HasMedia, TranslatableContract
     public function fillTranslations(array $translations): self
     {
         foreach ($translations as $locale => $data) {
-            if (! empty($data['title'])) {
+            if (!empty($data['title'])) {
+                // Get the translation for this locale (or create a new one)
+                $translation = $this->translateOrNew($locale);
+    
+                // Check if title has changed
+                if ($translation->title !== $data['title']) {
+                    $translation->title = $data['title'];
+                }
+    
+                // Handle the slug only if it has changed
                 $slug = $data['slug'] ?? Str::slug($data['title']);
-
-                // Ensure slug uniqueness per locale
-                $slug = $this->generateUniqueSlug($slug, $locale);
-
-                $this->translateOrNew($locale)->fill([
-                    'title' => $data['title'],
-                    'slug' => $slug,
-                    'content' => $data['content'] ?? null,
-                ]);
+                if ($translation->slug !== $slug) {
+                    $slug = $this->generateUniqueSlug($slug, $locale);
+                    $translation->slug = $slug;
+                }
+    
+                // Handle content only if it has changed
+                if ($translation->content !== ($data['content'] ?? null)) {
+                    $translation->content = $data['content'] ?? null;
+                }
+                
+                $translation->save();
             }
         }
-
+    
         return $this;
     }
-
-    private function generateUniqueSlug(string $slug, string $locale): string
+    public function generateUniqueSlug(string $slug, string $locale, int $counter = 0): string
     {
-        $originalSlug = $slug;
-        $count = 1;
-
-        while (TagTranslation::where('slug', $slug)->where('locale', $locale)->exists()) {
-            $slug = $originalSlug.'-'.$count;
-            $count++;
-        }
-
-        return $slug;
+        // Append counter if needed
+        $uniqueSlug = $counter > 0 ? "{$slug}-{$counter}" : $slug;
+    
+        // Check if the slug exists for this locale
+        $exists = static::whereHas('translations', function ($query) use ($uniqueSlug, $locale) {
+            $query->where('slug', $uniqueSlug)->where('locale', $locale);
+        })->exists();
+    
+        // If exists, try again with an incremented counter
+        return $exists ? $this->generateUniqueSlug($slug, $locale, $counter + 1) : $uniqueSlug;
     }
-
+    
     /**
      * Get all translations as a formatted array
      */