Merge pull request #9 from moremoban/dev

release 0.0.7

Author: chfw

CHANGELOG.rst

@@ -1,6 +1,13 @@
 Change log
 ================================================================================
 
+0.0.7 - 28.08.2020
+--------------------------------------------------------------------------------
+
+**Updated**
+
+#. raise UrlNotFound when request a non-existent url
+
 0.0.6 - 26.08.2020
 --------------------------------------------------------------------------------
 

changelog.yml

@@ -1,6 +1,12 @@
 name: gease
 organisation: moremoban
 releases:
+  - changes:
+      - action: Updated
+        details:
+          - "raise UrlNotFound when request a non-existent url"
+    date: 28.08.2020
+    version: 0.0.7
   - changes:
       - action: Updated
         details:

gease.yml

@@ -4,9 +4,9 @@ organisation: "moremoban"
 author: "C. W."
 contact: "wangc_2011@hotmail.com"
 company: "Onni Software Ltd."
-version: "0.0.6"
-current_version: 0.0.6
-release: "0.0.6"
+version: "0.0.7"
+current_version: 0.0.7
+release: "0.0.7"
 copyright_year: 2017-2020
 command_line_interface: gease
 entry_point: "gease.main:main"

gease/_version.py

@@ -1,3 +1,3 @@
-__version__ = '0.0.6'
+__version__ = '0.0.7'
 __author__ = 'C. W.'
 __description__ = 'simply makes a git release using github api v3'

gease/exceptions.py

@@ -20,3 +20,7 @@ class AbnormalGithubResponse(Exception):
 
 class UnhandledException(Exception):
     pass
+
+
+class UrlNotFound(Exception):
+    pass

gease/rest.py

@@ -54,7 +54,10 @@ def create(self, url, data):
 
     def get(self, url):
         r = self.__session.get(url)
-        return r.json()
+        if r.status_code == 200:
+            return r.json()
+        elif r.status_code == 404:
+            raise exceptions.UrlNotFound(f"{url} does not exist")
 
     @classmethod
     def get_api(cls):
@@ -63,7 +66,6 @@ def get_api(cls):
             cls.__instance = cls(token)
         return cls.__instance
 
-
     @classmethod
     def get_public_api(cls):
         cls.__instance = cls(None)

setup.py

@@ -32,7 +32,7 @@
 
 NAME = "gease"
 AUTHOR = "C. W."
-VERSION = "0.0.6"
+VERSION = "0.0.7"
 EMAIL = "wangc_2011@hotmail.com"
 LICENSE = "MIT"
 ENTRY_POINTS = {
@@ -45,7 +45,7 @@
     "simply makes a git release using github api v3"
 )
 URL = "https://github.com/moremoban/gease"
-DOWNLOAD_URL = "%s/archive/0.0.6.tar.gz" % URL
+DOWNLOAD_URL = "%s/archive/0.0.7.tar.gz" % URL
 FILES = ["README.rst", "CHANGELOG.rst"]
 KEYWORDS = [
     "python",
@@ -78,8 +78,8 @@
 }
 # You do not need to read beyond this line
 PUBLISH_COMMAND = "{0} setup.py sdist bdist_wheel upload -r pypi".format(sys.executable)
-GS_COMMAND = ("gs gease v0.0.6 " +
-              "Find 0.0.6 in changelog for more details")
+GS_COMMAND = ("gs gease v0.0.7 " +
+              "Find 0.0.7 in changelog for more details")
 NO_GS_MESSAGE = ("Automatic github release is disabled. " +
                  "Please install gease to enable it.")
 UPLOAD_FAILED_MSG = (

tests/test_api.py

@@ -3,6 +3,7 @@
 
 from gease.rest import Api
 from gease.exceptions import (
+    UrlNotFound,
     RepoNotFoundError,
     ReleaseExistException,
     AbnormalGithubResponse,
@@ -90,3 +91,11 @@ def test_unknown_error(self):
         )
         api = Api("test")
         api.create("http://localhost/", "cool")
+
+    @raises(UrlNotFound)
+    def test_get_unknown_url(self):
+        self.fake_session.return_value = MagicMock(
+            get=MagicMock(side_effect=UrlNotFound)
+        )
+        api = Api("test")
+        api.get("s")

tests/test_contributors.py

@@ -8,7 +8,7 @@ class TestPublish:
     @patch("gease.contributors.Api.get_public_api")
     def test_all_contributors(self, fake_api):
         sample_reply = [
-            {"login": "howdy", "url": "https://api.github.com/users/howdy",}
+            {"login": "howdy", "url": "https://api.github.com/users/howdy"}
         ]
         fake_api.return_value = MagicMock(
             get=MagicMock(side_effect=[sample_reply, {"name": "hello world"}])
@@ -30,7 +30,7 @@ def test_all_contributors(self, fake_api):
     @patch("gease.contributors.Api.get_public_api")
     def test_no_names(self, fake_api):
         sample_reply = [
-            {"login": "howdy", "url": "https://api.github.com/users/howdy",}
+            {"login": "howdy", "url": "https://api.github.com/users/howdy"}
         ]
         fake_api.return_value = MagicMock(
             get=MagicMock(side_effect=[sample_reply, {"name": None}])
@@ -41,5 +41,5 @@ def test_no_names(self, fake_api):
 
         eq_(
             contributors,
-            [{"name": "howdy", "url": "https://api.github.com/users/howdy",}],
+            [{"name": "howdy", "url": "https://api.github.com/users/howdy"}],
         )