🔨 code refactoring on magic labels

Author: chfw

docs/source/conf.py

@@ -59,4 +59,4 @@
 # Add any paths that contain custom static files (such as style sheets) here,
 # relative to this directory. They are copied after the builtin static files,
 # so a file named "default.css" will overwrite the builtin "default.css".
-html_static_path = ['static']
+html_static_path = ['static']

gitfs2/constants.py

@@ -1,5 +1,10 @@
 PROGRAM_NAME = "gitfs2"
 REPOS_DIR_NAME = "repos"
 
-MESSAGE_INVALID_GIT_URL = 'An invalid git url: "%s" in mobanfile'
+MESSAGE_INVALID_GIT_URL_FMT = 'An invalid git url: "%s" in mobanfile'
+MESSAGE_GIT_COMMAND_PROBLEM = "Unable to run git commands. Offline?"
+MESSAGE_FOUND_REPO_FMT = "Found local checkout in %s"
+MESSAGE_UPDATE_SUBMODULE = "updating submodule"
+MESSAGE_CHECKOUT_SUBMODULE = "checking out submodule"
+MESSAGE_GIT_CLONE_FMT = "git clone %s"
 DEFAULT_CLONE_DEPTH = 2

gitfs2/repo.py

@@ -69,26 +69,26 @@ def git_clone(require, action_required=True):
     if action_required:
         try:
             fs.open_fs(local_repo_folder)
-            reporter.info("Found repo in %s" % local_repo_folder)
+            reporter.info(constants.MESSAGE_FOUND_REPO_FMT % local_repo_folder)
             repo = Repo(local_repo_folder)
             repo.git.pull()
             if require.reference:
                 repo.git.checkout(require.reference)
             elif require.branch:
                 repo.git.checkout(require.branch)
             if require.submodule:
-                reporter.info("updating submodule")
+                reporter.info(constants.MESSAGE_UPDATE_SUBMODULE)
                 repo.git.submodule("update")
         except fs.errors.CreateFailed:
-            reporter.info("git clone %s" % require.git_url)
+            reporter.info(constants.MESSAGE_GIT_CLONE_FMT % require.git_url)
             repo = Repo.clone_from(
                 require.git_url, local_repo_folder, **require.clone_params()
             )
             if require.submodule:
-                reporter.info("checking out submodule")
+                reporter.info(constants.MESSAGE_CHECKOUT_SUBMODULE)
                 repo.git.submodule("update", "--init")
         except GitCommandError as e:
-            reporter.warn("Unable to run git commands. Offline?")
+            reporter.warn(constants.MESSAGE_GIT_COMMAND_PROBLEM)
             LOG.warn(e)
             return local_repo_folder
 
@@ -103,7 +103,7 @@ def get_repo_name(repo_url):
         repo = giturlparse.parse(repo_url.rstrip("/"))
         return repo.name
     except ParserError:
-        reporter.error(constants.MESSAGE_INVALID_GIT_URL % repo_url)
+        reporter.error(constants.MESSAGE_INVALID_GIT_URL_FMT % repo_url)
         raise