🐛 handle url not found exception when the github url is not yet ready/does not exist

Author: chfw

.github/workflows/moban-update.yml

@@ -5,23 +5,25 @@ jobs:
     runs-on: ubuntu-latest
     name: synchronize templates via moban
     steps:
-    - uses: actions/checkout@v2
-      with:
-        ref: ${{ github.head_ref }}
-    - name: Set up Python
-      uses: actions/setup-python@v1
-      with:
-        python-version: '3.7'
-    - name: check changes
-      run: |
-        pip install moban gitfs2 pypifs
-        moban
-        git status
-        git diff --exit-code
-    - name: Auto-commit
-      if: failure()
-      uses: docker://cdssnc/auto-commit-github-action
-      env:
-        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-      with:
-        args: This is an auto-commit, updating project meta data, such as changelog.rst, contributors.rst
+      - uses: actions/checkout@v2
+        with:
+          ref: ${{ github.head_ref }}
+      - name: Set up Python
+        uses: actions/setup-python@v1
+        with:
+          python-version: '3.7'
+      - name: check changes
+        run: |
+          pip install moban gitfs2 pypifs
+          moban
+          git status
+          git diff --exit-code
+      - name: Auto-commit
+        if: failure()
+        uses: docker://cdssnc/auto-commit-github-action
+        env:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        with:
+          args: >-
+            This is an auto-commit, updating project meta data,
+            such as changelog.rst, contributors.rst

changelog.yml

@@ -1,6 +1,12 @@
 name: moban-jinja2-github
 organisation: moremoban
 releases:
+- changes:
+  - action: first release
+    details:
+    - cope with new born project where github link is not ready. contributors list will be empty.
+  version: 0.0.2
+  date: 28.08.2020
 - changes:
   - action: first release
     details:

moban-jinja2-github.yml

@@ -2,10 +2,10 @@ name: "moban-jinja2-github"
 organisation: "moremoban"
 author: "chfw"
 contact: "[email protected]"
-company: "chfw"
-version: "0.0.1"
-current_version: "0.0.1"
-release: "0.0.1"
+company: "C.W."
+version: "0.0.2"
+current_version: "0.0.2"
+release: "0.0.2"
 copyright_year: 2020
 license: newbsd
 dependencies: 

moban_jinja2_github/contributors.py

@@ -1,9 +1,15 @@
+from gease.exceptions import UrlNotFound
 from gease.contributors import EndPoint
 
 
 def get_contributors(user, repo, author):
     repo = EndPoint(user, repo)
-    user_list = repo.get_all_contributors()
+    try:
+        user_list = repo.get_all_contributors()
 
-    user_list = [detail for detail in user_list if author not in detail["url"]]
-    return user_list
+        user_list = [
+            detail for detail in user_list if author not in detail["url"]
+        ]
+        return user_list
+    except UrlNotFound:
+        return []

tests/requirements.txt

@@ -8,6 +8,7 @@ isort
 collective.checkdocs
 pygments
 moban
+moban_jinja2_github
 moban
 black;python_version>="3.6"
 isort;python_version>="3.6"

tests/test_contributors.py

@@ -1,5 +1,6 @@
 from mock import MagicMock, patch
 from nose.tools import eq_
+from gease.exceptions import UrlNotFound
 
 
 @patch("moban_jinja2_github.contributors.EndPoint")
@@ -16,3 +17,18 @@ def test_get_contributors(fake_end_point):
     expected = [{"url": "contributors"}]
 
     eq_(list(actual), expected)
+
+
+@patch("moban_jinja2_github.contributors.EndPoint")
+def test_get_non_existent_url(fake_end_point):
+    fake_api = MagicMock(
+        get_all_contributors=MagicMock(side_effect=UrlNotFound)
+    )
+    fake_end_point.return_value = fake_api
+
+    from moban_jinja2_github.contributors import get_contributors
+
+    actual = get_contributors("user", "repo", "author")
+    expected = []
+
+    eq_(list(actual), expected)