Skip to content

Commit 28ea7bc

Browse files
authored
Merge pull request #49 from morficus/holiday-updates-legacy
Some minor holiday updates - addressing all dependbot security warnings - adding a GH action to run unit tests - adding a `CODEOWNERS` and PR template file - adding a `.nvm` file
2 parents c4c8e6e + 2775f87 commit 28ea7bc

File tree

6 files changed

+2084
-1596
lines changed

6 files changed

+2084
-1596
lines changed

.github/CODEOWNERS

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# Ths file defines individuals or teams that are responsible for code in a repository.
2+
# Code owners are automatically requested for review when someone opens a pull request that modifies code that they own.
3+
# Reference: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
4+
5+
* @morficus

.github/pull_request_template.md

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,34 @@
1+
# Description of changes
2+
3+
<!--
4+
Please fill out this section with a description of your changes and your approach to this ticket. Please make sure to include things such as:
5+
* A high-level description of your changes
6+
* Why did you take the approach that you took?
7+
* Are there any edge cases the reviewer should be aware of?
8+
* Are there any known limitations that will be addressed with a future change?
9+
-->
10+
11+
_fill me out 📝_
12+
13+
## How to test/verify these changes
14+
15+
<!--
16+
Replace the sample steps below with steps on how a reviewer of this PR can test your changes. This should include things such as (if applicable):
17+
* Do you need to use a specific account to log in?
18+
* Is there a particular patient profile that should be used?
19+
-->
20+
21+
1. Clone this branch and run: `npm run cypress`
22+
1. Next, do thing 1
23+
1. Now do thing 2
24+
1. Notice that XYZ has changed
25+
26+
27+
## Screenshots and/or video
28+
29+
<!--
30+
If relevant, make sure to include relevant video or before/after screenshots that demonstrate the changes.
31+
If no visuals are required, then please fill out this section with "N/A"
32+
-->
33+
34+
_fill me out 📸_
Lines changed: 62 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,62 @@
1+
# Run a number of quality checks ever time a PR is opened
2+
name: Pull Request Quality Checks
3+
4+
on:
5+
workflow_dispatch:
6+
inputs:
7+
name:
8+
description: 'Reason for manual trigger'
9+
required: true
10+
default: 'Re-run past failed build'
11+
12+
pull_request:
13+
types: [opened, synchronize]
14+
15+
jobs:
16+
setup:
17+
runs-on: ubuntu-latest
18+
19+
steps:
20+
# ref: https://github.com/marketplace/actions/checkout
21+
- name: Checkout code
22+
uses: actions/checkout@v4
23+
24+
# ref: https://github.com/marketplace/actions/setup-node-js-environment
25+
- name: Install NodeJS
26+
uses: actions/setup-node@v4
27+
with:
28+
node-version-file: '.nvmrc'
29+
30+
- name: Install dependencies
31+
run: npm ci --ignore-scripts
32+
env:
33+
CI: true
34+
35+
# we need to cache these dependencies so it can be used in the parallel jobs below
36+
- name: Cache dependencies
37+
uses: actions/cache@v4
38+
with:
39+
path: |
40+
./*
41+
~/.npm
42+
key: ${{ github.sha }}
43+
44+
unit-testing:
45+
name: Unit testing
46+
runs-on: ubuntu-latest
47+
needs: setup
48+
steps:
49+
# restore dependencies that were installed in the `setup` job
50+
- name: Restore dependencies
51+
uses: actions/cache@v3
52+
with:
53+
path: |
54+
./*
55+
~/.npm
56+
key: ${{ github.sha }}
57+
58+
- name: Testing
59+
run: npm test
60+
env:
61+
CI: true
62+
NODE_ENV: test

.nvmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
20

0 commit comments

Comments
 (0)