Some slight fix for KafkaRecoverableProducer

kenneth-jia · kenneth-jia · commit 14ce365deadd · 2021-10-20T16:07:35.000+08:00
diff --git a/include/kafka/addons/KafkaRecoverableProducer.h b/include/kafka/addons/KafkaRecoverableProducer.h
@@ -52,7 +52,8 @@ class KafkaRecoverableProducer
      */
     const std::string& name() const
     {
-        // lock
+        std::lock_guard<std::mutex> lock(_producerMutex);
+
         return _producer->name();
     }
 
@@ -312,7 +313,8 @@ class KafkaRecoverableProducer
             _producer->pollEvents(std::chrono::milliseconds(1));
             if (_fatalError)
             {
-                KAFKA_API_LOG(Log::Level::Notice, "met fatal error[%s], would re-initialze the internal producer");
+                const std::string errStr = _fatalError->toString();
+                KAFKA_API_LOG(Log::Level::Notice, "met fatal error[%s], will re-initialize the internal producer", errStr.c_str());
 
                 std::lock_guard<std::mutex> lock(_producerMutex);
 

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,8 @@ class KafkaRecoverableProducer`
`52`	`52`	`*/`
`53`	`53`	`const std::string& name() const`
`54`	`54`	`{`
`55`		`- // lock`
	`55`	`+ std::lock_guard<std::mutex> lock(_producerMutex);`
	`56`	`+`
`56`	`57`	`return _producer->name();`
`57`	`58`	`}`
`58`	`59`
`@@ -312,7 +313,8 @@ class KafkaRecoverableProducer`
`312`	`313`	`_producer->pollEvents(std::chrono::milliseconds(1));`
`313`	`314`	`if (_fatalError)`
`314`	`315`	`{`
`315`		`- KAFKA_API_LOG(Log::Level::Notice, "met fatal error[%s], would re-initialze the internal producer");`
	`316`	`+ const std::string errStr = _fatalError->toString();`
	`317`	`+ KAFKA_API_LOG(Log::Level::Notice, "met fatal error[%s], will re-initialize the internal producer", errStr.c_str());`
`316`	`318`
`317`	`319`	`std::lock_guard<std::mutex> lock(_producerMutex);`
`318`	`320`