Skip to content

Commit 1becf27

Browse files
committed
Upgrade to librdkafka v1.8.2
1 parent c710610 commit 1becf27

File tree

5 files changed

+11
-6
lines changed

5 files changed

+11
-6
lines changed

.github/workflows/kafka_api_bazel_build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
env:
1010
KAFKA_SRC_LINK: https://archive.apache.org/dist/kafka/2.8.1/kafka_2.13-2.8.1.tgz
1111
CPU_CORE_NUM: 2
12-
LIBRDKAFKA_VERSION: 1.7.0
12+
LIBRDKAFKA_VERSION: 1.8.2
1313

1414
jobs:
1515
kafka-api-bazel-build:

.github/workflows/kafka_api_ci_tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
env:
1010
KAFKA_SRC_LINK: https://archive.apache.org/dist/kafka/2.8.1/kafka_2.13-2.8.1.tgz
1111
CPU_CORE_NUM: 2
12-
LIBRDKAFKA_VERSION: 1.7.0
12+
LIBRDKAFKA_VERSION: 1.8.2
1313
BUILD_SUB_DIR: builds/sub-build
1414

1515
jobs:

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
The [Modern C++ Kafka API](http://opensource.morganstanley.com/modern-cpp-kafka/doxygen/annotated.html) is a layer of C++ wrapper based on [librdkafka](https://github.com/edenhill/librdkafka) (the C part), with high quality, but more friendly to users.
66

7-
- By now, [modern-cpp-kafka](https://github.com/morganstanley/modern-cpp-kafka) is compatible with [librdkafka v1.7.0](https://github.com/edenhill/librdkafka/releases/tag/v1.7.0).
7+
- By now, [modern-cpp-kafka](https://github.com/morganstanley/modern-cpp-kafka) is compatible with [librdkafka v1.8.2](https://github.com/edenhill/librdkafka/releases/tag/v1.8.2).
88

99
```
1010
KAFKA is a registered trademark of The Apache Software Foundation and

tests/integration/TestKafkaConsumer.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1422,6 +1422,7 @@ TEST(KafkaConsumer, SeekAfterPause)
14221422
}
14231423
}
14241424

1425+
// https://github.com/morganstanley/modern-cpp-kafka/issues/113
14251426
TEST(KafkaConsumer, DISABLED_SeekBeforePause)
14261427
{
14271428
const kafka::Topic topic = kafka::utility::getRandomString();

tests/robustness/TestKafkaConsumer.cc

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@
1414
#include <thread>
1515

1616

17-
TEST(KafkaConsumer, AlwaysFinishClosing_ManuallyPollEvents)
17+
// https://github.com/morganstanley/modern-cpp-kafka/issues/120
18+
TEST(KafkaConsumer, DISABLED_AlwaysFinishClosing_ManuallyPollEvents)
1819
{
1920
const kafka::Topic topic = kafka::utility::getRandomString();
2021
const kafka::Partition partition = 0;
@@ -81,7 +82,8 @@ TEST(KafkaConsumer, AlwaysFinishClosing_ManuallyPollEvents)
8182
KafkaTestUtility::ResumeBrokers();
8283
}
8384

84-
TEST(KafkaConsumer, CommitOffsetWhileBrokersStop)
85+
// https://github.com/morganstanley/modern-cpp-kafka/issues/120
86+
TEST(KafkaConsumer, DISABLED_CommitOffsetWhileBrokersStop)
8587
{
8688
const kafka::Topic topic = kafka::utility::getRandomString();
8789
const kafka::Partition partition = 0;
@@ -98,7 +100,9 @@ TEST(KafkaConsumer, CommitOffsetWhileBrokersStop)
98100
const auto props = KafkaTestUtility::GetKafkaClientCommonConfig()
99101
.put(kafka::clients::consumer::Config::MAX_POLL_RECORDS, "1") // Only poll 1 message each time
100102
.put(kafka::clients::consumer::Config::AUTO_OFFSET_RESET, "earliest")
101-
.put(kafka::clients::consumer::Config::SOCKET_TIMEOUT_MS, "2000"); // Just don't want to wait too long for the commit-offset callback.
103+
.put(kafka::clients::consumer::Config::SOCKET_TIMEOUT_MS, "2000") // Just don't want to wait too long for the commit-offset callback.
104+
.put("log_level", "7")
105+
.put("debug", "all");
102106

103107
volatile std::size_t commitCbCount = 0;
104108
{

0 commit comments

Comments
 (0)