Improve Security

Author: kenneth-jia

include/kafka/Properties.h

@@ -160,7 +160,7 @@ class Properties
                           const std::string& key   = kv.first;
                           const std::string  value = kv.second.toString();
 
-                          static const std::regex reSensitiveKey(R"(.+\.password|.+\.username|.+secret)");
+                          static const std::regex reSensitiveKey(R"(.+\.password|.+\.username|.+secret|.+key|.+pem)");
                           const bool isSensitive = std::regex_match(key, reSensitiveKey);
 
                           ret.append(ret.empty() ? "" : "|").append(key).append("=").append(isSensitive ? "*" : value);

tests/unit/TestProperties.cc

@@ -120,7 +120,9 @@ TEST(Properties, SensitiveProperties)
         { "ssl.keystore.password", { "passwordB" } },
         { "sasl.username",         { "userName"  } },
         { "sasl.password",         { "passwordC" } },
+        { "ssl.key.pem",           { "pem"       } },
+        { "ssl_key",               { "key"       } },
     }};
 
-    EXPECT_EQ("sasl.password=*|sasl.username=*|ssl.key.password=*|ssl.keystore.password=*", props.toString());
+    EXPECT_EQ("sasl.password=*|sasl.username=*|ssl.key.password=*|ssl.key.pem=*|ssl.keystore.password=*|ssl_key=*", props.toString());
 }