Remove sensitive info from log

Author: kenneth-jia

include/kafka/Properties.h

@@ -6,6 +6,7 @@
 
 #include <algorithm>
 #include <map>
+#include <regex>
 #include <string>
 
 
@@ -71,10 +72,17 @@ class Properties
 
     std::string toString() const
     {
+
         std::string ret;
         std::for_each(_kvMap.cbegin(), _kvMap.cend(),
                       [&ret](const auto& kv) {
-                          ret.append(ret.empty() ? "" : "|").append(kv.first).append("=").append(kv.second);
+                          const std::string& key   = kv.first;
+                          const std::string& value = kv.second;
+
+                          static const std::regex reSensitiveKey(R"(.+\.password)");
+                          bool isSensitive = std::regex_match(key, reSensitiveKey);
+
+                          ret.append(ret.empty() ? "" : "|").append(key).append("=").append(isSensitive ? "*" : value);
                       });
         return ret;
     }

tests/unit/TestProperties.cc

@@ -83,3 +83,15 @@ TEST(Properties, AdminClientConfig)
 
     EXPECT_EQ("bootstrap.servers=127.0.0.1:9000,127.0.0.1:9001|security.protocol=SASL_PLAINTEXT", props.toString());
 }
+
+TEST(Properties, SensitiveProperties)
+{
+    kafka::Properties props
+    {{
+        { "ssl.key.password",      "passwordA" },
+        { "ssl.keystore.password", "passwordB" },
+        { "sasl.password",         "passwordC" },
+    }};
+
+    EXPECT_EQ("sasl.password=*|ssl.key.password=*|ssl.keystore.password=*", props.toString());
+}