- 
                Notifications
    You must be signed in to change notification settings 
- Fork 99
Open
Description
In the file KafkaClient.h at line
modern-cpp-kafka/include/kafka/KafkaClient.h
Line 590 in a146d10
| if (rd_kafka_oauthbearer_set_token(rk, | 
https://github.com/confluentinc/librdkafka/blob/0e3128c69a2faec988850da8e78ea077a3fc3019/src/rdkafka.h#L9899
the md_lifetime_ms is in millisecond, but the parameter SaslOauthbearerToken we pass in is microseconds, it is in
| std::chrono::microseconds mdLifetime{}; | 
We should probably change mdLifetime's type to std::chrono::milliseconds as below
struct SaslOauthbearerToken
    {
        using KeyValuePairs = std::map<std::string, std::string>;
        std::string               value;
        std::chrono::milliseconds mdLifetime{};
        std::string               mdPrincipalName;
        KeyValuePairs             extensions;
    };
Metadata
Metadata
Assignees
Labels
No labels