Skip to content

Commit 3c6115b

Browse files
frewilhelmocmbot[bot]morri-son
authored
fix(deps): adjust creation of chart README.md (open-component-model#1905)
<!-- markdownlint-disable MD041 --> #### What this PR does / why we need it open-component-model#1881 fails because it updates the image tag with pinned digest in the README.md. This is unwanted behaviour because it makes the README.md unreadable. The adjustment in the Task `helm/docs` remove any pinned digest from the README.md #### Which issue(s) this PR fixes Fixes and supersedes open-component-model#1881 #### Testing Check out this branch and run `task helm/docs` in `kubernetes/controller` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Pinned external dependencies and container images to specific versions, ensuring reproducible builds, enhanced security through image immutability, and consistent deployments across all environments. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Frederic Wilhelm <frederic.wilhelm@sap.com> Co-authored-by: ocmbot[bot] <125909804+ocmbot[bot]@users.noreply.github.com> Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com>
1 parent 66b9926 commit 3c6115b

File tree

5 files changed

+9
-5
lines changed

5 files changed

+9
-5
lines changed

.github/workflows/conformance.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ jobs:
4747
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
4848
with:
4949
sparse-checkout: conformance/scenarios/sovereign
50-
- uses: actions/setup-go@v6
50+
- uses: actions/setup-go@4b73464bb391d4059bd26b0524d20df3927bd417 # v6
5151
with:
5252
go-version-file: conformance/scenarios/sovereign/components/notes/go.mod
5353
- name: Install Task

conformance/scenarios/sovereign/components/notes/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
# Multi-stage build for sovereign-notes application
2-
FROM golang:1.25-alpine AS builder
2+
FROM golang:1.25-alpine@sha256:f6751d823c26342f9506c03797d2527668d095b0a15f1862cddb4d927a7a4ced AS builder
33

44
# Set working directory
55
WORKDIR /app

conformance/scenarios/sovereign/components/postgres/deploy/chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ replicaCount: 1
44
image:
55
repository: postgres
66
pullPolicy: IfNotPresent
7-
tag: "18"
7+
tag: "18@sha256:69e8582b781cb44fa4557b98ed586fe68361e320d9b12f9707494335634f4f3d"
88

99
nameOverride: ""
1010
fullnameOverride: "postgres"

kubernetes/controller/Taskfile.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -216,7 +216,11 @@ tasks:
216216
desc: "Generate Helm chart documentation"
217217
deps: [helm-docs]
218218
dir: chart
219-
cmd: '"{{.HELM_DOCS}}"'
219+
cmds:
220+
- '"{{.HELM_DOCS}}"'
221+
# Strip SHA digests from README.md for cleaner documentation
222+
# The digest is kept in values.yaml for security, but removed from docs for readability
223+
- sed -i'' -e 's/@sha256:[a-f0-9]\{64\}//g' README.md
220224
sources:
221225
- chart/values.yaml
222226
- chart/README.md

kubernetes/controller/chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ manager:
1212
# -- Controller image repository
1313
repository: ghcr.io/open-component-model/kubernetes/controller
1414
# -- Controller image tag
15-
tag: latest
15+
tag: latest@sha256:5580df055651f7d28557d502157d29d6b11bc7b303d110dd9e605220b1481759
1616
# -- Image pull policy
1717
pullPolicy: IfNotPresent
1818
## Controller concurrency settings

0 commit comments

Comments
 (0)