Skip to content

Commit ad2fbdc

Browse files
committed
fix: gh release view requires --repo param, add default changelog message
Bug 1: gh release view in release_final job failed with 'not a git repository' because the job has no checkout. Added --repo parameter. Bug 2: Empty release notes when no commits found on new release branch. Added default changelog message for initial RC releases. On-behalf-of: Gerald Morrison (SAP) <gerald.morrison@sap.com> Signed-off-by: Gerald Morrison (SAP) <gerald.morrison@sap.com>
1 parent e7cde0c commit ad2fbdc

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/cli-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ jobs:
431431
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
432432
RC_TAG: ${{ needs.prepare.outputs.latest_rc_tag }}
433433
NOTES_FILE: ${{ runner.temp }}/RELEASE_NOTES.md
434-
run: gh release view "$RC_TAG" --json body --jq '.body // ""' > "$NOTES_FILE"
434+
run: gh release view "$RC_TAG" --repo "${{ github.repository }}" --json body --jq '.body // ""' > "$NOTES_FILE"
435435

436436
- name: Publish final release with RC assets
437437
uses: actions/github-script@ed597411d8f924073f98dfc5c65a23a2325f34cd # v8

0 commit comments

Comments
 (0)