Skip to content

Commit 942ce3c

Browse files
authored
Update: Replace Object.keys with Object.entries. Update dependencies. (#30)
* Update: - * Update: -
1 parent fc02b74 commit 942ce3c

File tree

8 files changed

+1729
-966
lines changed

8 files changed

+1729
-966
lines changed

.npmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
save-exact=true

examples/umd/.npmrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
save-exact=true

examples/umd/package-lock.json

Lines changed: 650 additions & 417 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/umd/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@
1010
"license": "ISC",
1111
"description": "",
1212
"devDependencies": {
13-
"webpack": "^4.30.0",
14-
"webpack-cli": "^3.3.1"
13+
"webpack": "4.41.3",
14+
"webpack-cli": "3.3.10"
1515
},
1616
"dependencies": {
17-
"react": "^16.8.6"
17+
"react": "16.12.0"
1818
}
1919
}

examples/umd/webpack.config.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@ const MicroservicesWebpackPlugin = require('./../../lib/index.js');
44

55

66
module.exports = {
7+
mode: 'production',
78
entry: resolve(__dirname, 'src', 'index.js'),
89
output: {
910
path: resolve(__dirname, 'dist'),
1011
libraryTarget: 'amd'
1112
},
12-
plugins: [
13+
plugins: [
1314
new MicroservicesWebpackPlugin({
1415
modules: [
1516
{ name: 'react', path: `umd/react.production.min.js` },

lib/index.js

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
const { RawSource } = require('webpack-sources');
22
const npmCheck = require('npm-check');
3+
const fromEntries = require('object.fromentries');
34

45

56
class MicroservicesWebpackPlugin {
@@ -48,29 +49,28 @@ class MicroservicesWebpackPlugin {
4849
async tapAsync(compilation, callback) {
4950
this.modules = await this.createUrlsToModules(this.modules);
5051

51-
compilation.assets = Object.keys(compilation.assets)
52-
.map((fileName) => {
53-
if (!fileName.includes('.js')) {
54-
return {[fileName]: compilation.assets[fileName]};
55-
}
52+
compilation.assets = fromEntries(Object.entries(compilation.assets)
53+
.map(([fileName, asset]) => {
54+
if (!fileName.includes('.js')) {
55+
return [fileName, asset];
56+
}
5657

57-
const source = compilation.assets[fileName].source();
58-
const supportAmdOnly = 'define(';
58+
const source = asset.source();
59+
const supportAmdOnly = 'define(';
5960

60-
if (!source.startsWith(supportAmdOnly)) {
61-
return {[fileName]: compilation.assets[fileName]};
61+
if (!source.startsWith(supportAmdOnly)) {
62+
return [fileName, asset];
6263
}
6364

64-
const value = [
65-
this.modules
66-
.map(({ cdn, name }) => `define('${name}', ['${cdn}'], function(v) {return v;})`)
67-
.join('\n'),
65+
const value = [
66+
this.modules
67+
.map(({ cdn, name }) => `define('${name}', ['${cdn}'], function(v) {return v;})`)
68+
.join('\n'),
6869
source
69-
].join('\n');
70+
].join('\n');
7071

71-
return {[fileName]: new RawSource(value)};
72-
})
73-
.reduce((previous, current) => ({ ...previous, ...current }), {});
72+
return [fileName, new RawSource(value)];
73+
}));
7474

7575
callback()
7676
}

0 commit comments

Comments
 (0)