Miscelleaneous bug fixes & improvements (#1264)

* Fix usage of deprecated "cpuid" Bochs option

Signed-off-by: AnErrupTion <[email protected]>

* Parse static options first in kernel

Signed-off-by: AnErrupTion <[email protected]>

* Add extern method module not found error

Signed-off-by: AnErrupTion <[email protected]>

* Reset instruction stage after refresh in Explorer

Signed-off-by: AnErrupTion <[email protected]>

* Make large text boxes' font monospace in Explorer

Signed-off-by: AnErrupTion <[email protected]>

* Add Mosa.UnitTests.TinyCoreLib in UnitTests folder

Signed-off-by: AnErrupTion <[email protected]>

* Fix SCCP constant value for null objects

Signed-off-by: AnErrupTion <[email protected]>

---------

Signed-off-by: AnErrupTion <[email protected]>

Author: AnErrupTion

Source/Mosa.Compiler.Framework/MethodCompiler.cs

@@ -587,11 +587,7 @@ private void ExternalMethod()
 
 		if (filename != null)
 		{
-			var bytes = Compiler.SearchPathsForFileAndLoad(filename);
-
-			// TODO: Generate an error if the file is not found
-			// CompilerException.FileNotFound
-
+			var bytes = Compiler.SearchPathsForFileAndLoad(filename) ?? throw new CompilerException($"Could not find extern method module: {filename}");
 			Symbol.SetData(bytes);
 		}
 

Source/Mosa.Compiler.Framework/Stages/SparseConditionalConstantPropagationStage.cs

@@ -92,9 +92,13 @@ protected void ReplaceVirtualRegisterWithConstant(Operand target, ulong value)
 		{
 			Debug.Assert(!target.IsFloatingPoint);
 
-			var constant = target.IsInt32
-				? Operand.CreateConstant32((uint)value)
-				: Operand.CreateConstant64(value);
+			Operand constant;
+			if (target.IsInt32)
+				constant = Operand.CreateConstant32((uint)value);
+			else if (target.IsInt64)
+				constant = Operand.CreateConstant64(value);
+			else
+				constant = Operand.NullObject;
 
 			// for each statement T that uses operand, substituted c in statement T
 			foreach (var node in target.Uses.ToArray())

Source/Mosa.Kernel.BareMetal/BootOptions.cs

@@ -28,22 +28,22 @@ public static void Setup()
 
 	public static string GetValue(string key)
 	{
-		var result = GetValue(RuntimeOptions, key);
+		var result = GetValue(StaticOptions, key);
 
 		if (string.IsNullOrEmpty(result))
 		{
-			result = GetValue(StaticOptions, key);
+			result = GetValue(RuntimeOptions, key);
 		}
 
 		return result;
 	}
 
 	public static bool Contains(string value)
 	{
-		if (Contains(RuntimeOptions, value))
+		if (Contains(StaticOptions, value))
 			return true;
 
-		return Contains(StaticOptions, value);
+		return Contains(RuntimeOptions, value);
 	}
 
 	private static string GetValue(Pointer options, string key)

Source/Mosa.Linux.sln

@@ -1438,6 +1438,7 @@ Global
 		{FBC3B0CD-D775-41C6-A735-F59118838397} = {D032B24A-CE3A-4881-BACE-CC4FE0AFD69D}
 		{3347E41D-AD8B-4891-9A9B-5EE36BACA6F1} = {90065B0F-1BFE-40D8-AED5-11096B2535B0}
 		{844037C4-B018-4AD0-8237-BAE46E024994} = {079CE6E3-8038-44F5-B18A-2D586A827D95}
+		{F74513A5-E5B4-4ABC-9E8B-999EC55FCFC6} = {88D3D1D0-85D2-4301-A9EA-3F964CB05415}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {C22A5C94-6B05-4B1B-845A-A2EA7615E093}

Source/Mosa.Tool.Explorer.Avalonia/MainWindow.axaml

@@ -90,7 +90,7 @@
 							<Button Name="SaveB" Click="SaveB_OnClick">Save B</Button>
 						</StackPanel>
 
-						<TextBox Grid.Row="1" Name="Instructions" IsReadOnly="True"/>
+						<TextBox Grid.Row="1" Name="Instructions" FontFamily="Monospace" IsReadOnly="True"/>
 					</Grid>
 				</TabItem>
 
@@ -106,7 +106,7 @@
 						</StackPanel>
 
 						<Grid Grid.Row="1" ColumnDefinitions="*, 5, *">
-							<TextBox Grid.Column="0" Name="Debug" IsReadOnly="True"/>
+							<TextBox Grid.Column="0" Name="Debug" FontFamily="Monospace" IsReadOnly="True"/>
 							<GridSplitter Grid.Column="1"/>
 							<Panel Grid.Column="2" Name="DebugPanel"/>
 						</Grid>
@@ -142,7 +142,7 @@
 									<Label Name="Total">##</Label>
 								</StackPanel>
 
-								<TextBox Grid.Row="1" Name="Transforms" IsReadOnly="True"/>
+								<TextBox Grid.Row="1" Name="Transforms" FontFamily="Monospace" IsReadOnly="True"/>
 							</Grid>
 
 							<GridSplitter Grid.Column="1"/>
@@ -181,7 +181,7 @@
 							</Grid>
 						</StackPanel>
 
-						<TextBox Grid.Row="1" Name="CompilerLogs" IsReadOnly="True"/>
+						<TextBox Grid.Row="1" Name="CompilerLogs" FontFamily="Monospace" IsReadOnly="True"/>
 					</Grid>
 				</TabItem>
 

Source/Mosa.Tool.Explorer.Avalonia/MainWindow.axaml.cs

@@ -659,6 +659,8 @@ private bool ShowGraphviz()
 
 	private void OpenFile()
 	{
+		InstructionsStage.SelectedIndex = -1;
+
 		UpdateSettings();
 		UpdateSettings(lastOpenedFile);
 		LoadAssembly();

Source/Mosa.Utility.Launcher/Starter.cs

@@ -384,7 +384,7 @@ private Process LaunchBochs()
 		sb.AppendLine(MosaSettings.EmulatorMemory.ToString());
 
 		sb.AppendLine("ata0: enabled=1,ioaddr1=0x1f0,ioaddr2=0x3f0,irq=14");
-		sb.AppendLine("cpuid: mmx=1,sep=1,simd=sse4_2,apic=xapic,aes=1,movbe=1,xsave=1");
+		sb.AppendLine("cpu: model=core2_penryn_t9600, count=1");
 		sb.AppendLine("boot: cdrom,disk");
 
 		sb.Append("log: \"");

Source/Mosa.sln

@@ -1494,6 +1494,7 @@ Global
 		{763FDCF2-2501-4756-A7A1-62813D610B00} = {D032B24A-CE3A-4881-BACE-CC4FE0AFD69D}
 		{B940F546-628B-45C0-9FA5-4479F166033F} = {90065B0F-1BFE-40D8-AED5-11096B2535B0}
 		{0E0E772E-5824-4ABA-8524-AA0B00BBD9BB} = {079CE6E3-8038-44F5-B18A-2D586A827D95}
+		{5B6E6C85-E89B-4384-96F2-69B1F3524EA5} = {88D3D1D0-85D2-4301-A9EA-3F964CB05415}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {C22A5C94-6B05-4B1B-845A-A2EA7615E093}