crystal 0.20.4

Author: mosop

spec/internal/dynamic_validation_spec.cr

@@ -5,11 +5,11 @@ module CliInternalDynamicValidationFeature
 
   class Command < Cli::Command
     class Options
-      # arg_array "name" do |definition|
-      #   definition.on_validate do |context|
-      #     context.validate_element_inclusion context.command.expected
-      #   end
-      # end
+      arg_array "name" do |definition|
+        definition.on_validate do |context, options|
+          context.validate_element_inclusion options.command.expected
+        end
+      end
     end
 
     def expected
@@ -19,19 +19,19 @@ module CliInternalDynamicValidationFeature
 
   class Command2 < Cli::Command
     class Options
-      # arg_array "name" do |definition|
-      #   definition.on_validate do |context|
-      #     context.validate_element_inclusion context.command.expected2
-      #   end
-      # end
+      arg_array "name" do |definition|
+        definition.on_validate do |context, options|
+          context.validate_element_inclusion options.command.expected2
+        end
+      end
     end
 
     def expected2
       %w(foo bar baz)
     end
   end
 
-  pending name do
+  it name do
     Command.run(%w(other)).should exit_command(error: /^Parsing Error: /)
     Command2.run(%w(other)).should exit_command(error: /^Parsing Error: /)
   end

src/lib/helps/base.cr

@@ -126,7 +126,7 @@ module Cli::Helps
 
     def inclusion_of2(incl)
       a = incl.values.map do |v|
-        desc = if md = v.metadata.as?(OptionValueMetadata)
+        desc = if md = v.metadata.as?(OptionValueMetadata(String))
           md.description
         end
         Description.new(head: v.metadata.string, body: desc ? desc.split("\n") : %w())