Refactoring _listEventSourceMappings (#339)

* Refactoring _listEventSourceMappings

Modify that _listEventSourceMappings returns Promise

* Remove unnecessary catch

Author: abetomo

lib/main.js

@@ -566,13 +566,15 @@ Lambda.prototype._buildAndArchive = function (program) {
   })
 }
 
-Lambda.prototype._listEventSourceMappings = function (lambda, params, cb) {
-  return lambda.listEventSourceMappings(params, function (err, data) {
-    var eventSourceMappings = []
-    if (!err && data && data.EventSourceMappings) {
-      eventSourceMappings = data.EventSourceMappings
-    }
-    return cb(err, eventSourceMappings)
+Lambda.prototype._listEventSourceMappings = (lambda, params) => {
+  return new Promise((resolve, reject) => {
+    lambda.listEventSourceMappings(params, (err, data) => {
+      if (err) return reject(err)
+      if (data && data.EventSourceMappings) {
+        return resolve(data.EventSourceMappings)
+      }
+      return resolve([])
+    })
   })
 }
 
@@ -764,11 +766,9 @@ Lambda.prototype._deployToRegion = function (program, params, region) {
       'FunctionName': params.FunctionName
     }).promise().then(() => {
       // Function exists
-      _this._listEventSourceMappings(lambda, {
+      return _this._listEventSourceMappings(lambda, {
         'FunctionName': params.FunctionName
-      }, (err, existingEventSourceList) => {
-        if (err) return reject(err)
-
+      }).then((existingEventSourceList) => {
         return Promise.all([
           _this._uploadExisting(lambda, params).then((results) => {
             console.log('=> Zip file(s) done uploading. Results follow: ')
@@ -787,9 +787,9 @@ Lambda.prototype._deployToRegion = function (program, params, region) {
           )
         ]).then((results) => {
           resolve(results)
-        }).catch((err) => {
-          reject(err)
         })
+      }).catch((err) => {
+        reject(err)
       })
     }).catch(() => {
       // Function does not exist
@@ -811,8 +811,6 @@ Lambda.prototype._deployToRegion = function (program, params, region) {
           )
         ]).then((results) => {
           resolve(results)
-        }).catch((err) => {
-          reject(err)
         })
       }).catch((err) => {
         reject(err)

test/main.js

@@ -790,6 +790,20 @@ describe('lib/main', function () {
     })
   })
 
+  describe('_listEventSourceMappings', () => {
+    it('simple test with mock', () => {
+      return lambda._listEventSourceMappings(
+        awsLambda,
+        { FunctionName: 'test-func' }
+      ).then((results) => {
+        assert.deepEqual(
+          results,
+          lambdaMockSettings.listEventSourceMappings.EventSourceMappings
+        )
+      })
+    })
+  })
+
   describe('_updateEventSources', () => {
     const eventSourcesJsonValue = {
       EventSourceMappings: [{