Fix symlink at zip (#348)

* Upgrade archiver

In addition I also did the following.
- npm update
- yarn upgrade

* Fix to handle symlink when zipping

* Modify timing to execute stat acquisition

* Supports nodejs4

It seems that usage of constants is different depending on version

* Fix not to test symlink on Windows

Author: abetomo

lib/main.js

@@ -406,9 +406,7 @@ Lambda.prototype._zip = (program, codeDirectory) => {
 
         const filePath = file.path.replace(path.join(codeDirectory, path.sep), '')
         if (file.stats.isSymbolicLink()) {
-          // # archiver.js
-          // Implementation supporting symlink has been done,
-          // but it seems that release has not been done yet
+          return archive.symlink(filePath, fs.readlinkSync(file.path))
         }
 
         archive.append(

package-lock.json

@@ -36,9 +36,9 @@
     "standard": "^10.0.2"
   },
   "dependencies": {
-    "archiver": "^1.3.0",
-    "aws-sdk": "^2.76.0",
-    "commander": "^2.10.0",
+    "archiver": "^2.0.0",
+    "aws-sdk": "^2.81.0",
+    "commander": "^2.11.0",
     "dotenv": "^0.4.0",
     "fs-extra": "^0.30.0",
     "minimatch": "^3.0.3",

package.json

@@ -529,21 +529,27 @@ describe('lib/main', function () {
         return lambda._fileCopy(program, '.', codeDirectory, true)
       }).then(() => {
         return lambda._npmInstall(program, codeDirectory)
+      }).then(() => {
+        if (process.platform !== 'win32') {
+          fs.symlinkSync(
+            path.join(__dirname, '..', 'bin', 'node-lambda'),
+            path.join(codeDirectory, 'node-lambda-link')
+          )
+        }
       })
     })
 
     it('Compress the file. `index.js` and `bin/node-lambda` are included and the permission is also preserved.', function () {
       _timeout({ this: this, sec: 30 }) // give it time to zip
 
       return lambda._zip(program, codeDirectory).then((data) => {
-        const indexJsStat = fs.lstatSync('index.js')
-        const binNodeLambdaStat = fs.lstatSync(path.join('bin', 'node-lambda'))
-
         const archive = new Zip(data)
         assert.include(archive.files['index.js'].name, 'index.js')
         assert.include(archive.files['bin/node-lambda'].name, 'bin/node-lambda')
 
         if (process.platform !== 'win32') {
+          const indexJsStat = fs.lstatSync('index.js')
+          const binNodeLambdaStat = fs.lstatSync(path.join('bin', 'node-lambda'))
           assert.equal(
             archive.files['index.js'].unixPermissions,
             indexJsStat.mode
@@ -552,6 +558,14 @@ describe('lib/main', function () {
             archive.files['bin/node-lambda'].unixPermissions,
             binNodeLambdaStat.mode
           )
+
+          // isSymbolicLink
+          assert.include(archive.files['node-lambda-link'].name, 'node-lambda-link')
+          const fsConstants = process.binding('constants').fs || require('constants')
+          assert.equal(
+            archive.files['node-lambda-link'].unixPermissions & fsConstants.S_IFMT,
+            fsConstants.S_IFLNK
+          )
         }
       })
     })