Add invalidation of log output to make the test result easier to read (#367)

* Add function to enable / disable console.[log, warn, info]

* Remove meaningless test

* Add invalidation of log output to make the test result easier to read

Author: abetomo

test/main.js

@@ -113,6 +113,18 @@ const _awsRestore = () => {
   awsMock.restore('Lambda')
 }
 
+const disableLog = () => {
+  ['log', 'warn', 'info'].forEach((f) => {
+    console[f] = () => {}
+  })
+}
+
+const enableLog = () => {
+  ['log', 'warn', 'info'].forEach((f) => {
+    if (String(console[f]) === '() => {}') delete console[f]
+  })
+}
+
 /* global before, after, beforeEach, afterEach, describe, it */
 describe('lib/main', function () {
   if (process.platform === 'win32') {
@@ -508,16 +520,18 @@ describe('lib/main', function () {
     })
 
     it('should not throw any errors if no script', () => {
+      disableLog()
       return lambda._postInstallScript(program, codeDirectory).then((dummy) => {
+        enableLog()
         assert.isUndefined(dummy)
       })
     })
 
     it('should throw any errors if script fails', () => {
       fs.writeFileSync(postInstallScriptPath, '___fails___')
-      return lambda._postInstallScript(program, codeDirectory).then((dummy) => {
-        assert.isUndefined(dummy)
-      }).catch((err) => {
+      disableLog()
+      return lambda._postInstallScript(program, codeDirectory).catch((err) => {
+        enableLog()
         assert.instanceOf(err, Error)
         assert.match(err.message, /^Error: Command failed:/)
       })
@@ -563,7 +577,9 @@ describe('lib/main', function () {
     it('Compress the file. `index.js` and `bin/node-lambda` are included and the permission is also preserved.', function () {
       _timeout({ this: this, sec: 30 }) // give it time to zip
 
+      disableLog()
       return lambda._zip(program, codeDirectory).then((data) => {
+        enableLog()
         const archive = new Zip(data)
         assert.include(archive.files['index.js'].name, 'index.js')
         assert.include(archive.files['bin/node-lambda'].name, 'bin/node-lambda')
@@ -597,7 +613,9 @@ describe('lib/main', function () {
     it('installs and zips with an index.js file and node_modules/aws-sdk (It is also a test of `_buildAndArchive`)', function () {
       _timeout({ this: this, sec: 30 }) // give it time to zip
 
+      disableLog()
       return lambda._archive(program).then((data) => {
+        enableLog()
         const archive = new Zip(data)
         const contents = Object.keys(archive.files).map((k) => {
           return archive.files[k].name.toString()
@@ -620,7 +638,9 @@ describe('lib/main', function () {
       fs.writeFileSync(path.join(buildDir, 'd', 'testb'), '...')
 
       program.prebuiltDirectory = buildDir
+      disableLog()
       return lambda._archive(program).then((data) => {
+        enableLog()
         const archive = new Zip(data)
         const contents = Object.keys(archive.files).map((k) => {
           return archive.files[k].name.toString()
@@ -642,7 +662,9 @@ describe('lib/main', function () {
     before(function () {
       _timeout({ this: this, sec: 30 }) // give it time to zip
 
+      disableLog()
       return lambda._zip(program, codeDirectory).then((data) => {
+        enableLog()
         bufferExpected = data
         fs.writeFileSync(testZipFile, data)
       })
@@ -682,7 +704,9 @@ describe('lib/main', function () {
         const filePath = path.join(path.resolve('/aaaa'), 'bbbb')
         const _program = Object.assign({ deployZipfile: filePath }, program)
         _timeout({ this: this, sec: 30 }) // give it time to zip
+        disableLog()
         return lambda._archive(_program).then((data) => {
+          enableLog()
           // same test as "installs and zips with an index.js file and node_modules/aws-sdk"
           const archive = new Zip(data)
           const contents = Object.keys(archive.files).map((k) => {
@@ -736,7 +760,9 @@ describe('lib/main', function () {
     })
 
     it('should create sample files', () => {
+      disableLog()
       lambda.setup(program)
+      enableLog()
 
       const libPath = path.join(__dirname, '..', 'lib')
       targetFiles.forEach((targetFile) => {
@@ -1039,7 +1065,9 @@ describe('lib/main', function () {
       program.eventFile = 'newEvent.json'
       program.contextFile = 'newContext.json'
 
+      disableLog()
       lambda.setup(program)
+      enableLog()
 
       assert.equal(fs.readFileSync('newContext.json').toString(), '{"FOO"="bar"\n"BAZ"="bing"\n}')
       assert.equal(fs.readFileSync('newEvent.json').toString(), '{"FOO"="bar"}')